All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Pratyush Anand <pratyush.anand@st.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Mohit KUMAR DCG <Mohit.KUMAR@st.com>,
	"spear-devel" <spear-devel@list.st.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH V3 4/8] phy: Initialize phy core with subsys_initcall
Date: Fri, 31 Jan 2014 16:25:53 +0100	[thread overview]
Message-ID: <201401311625.53846.arnd@arndb.de> (raw)
In-Reply-To: <20140131034803.GA2618@pratyush-vbox>

On Friday 31 January 2014, Pratyush Anand wrote:
> > Having the PHY driver get initialized after the PCI root driver should
> > also work, but it requires correct handling of -EPROBE_DEFER: if phy_get
> 
> I had issue with phy-core driver getting initialized after pcie rc
> driver. I found a kernel crash, as devm_phy_get was called before
> phy_class was created. I think this too need to be fixed, we should
> not see a crash.

Yes, agreed. This should be trivial to do though.

> Anyway, I will keep spear phy and rc driver both with module_init and
> -EPROBE_DEFER implementation.

Ok.

	Arnd

  reply	other threads:[~2014-01-31 15:26 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 10:48 [PATCH V3 0/8] PCI:Add SPEAr13xx PCie support Mohit Kumar
2014-01-30 10:48 ` Mohit Kumar
2014-01-30 10:48 ` Mohit Kumar
2014-01-30 10:48 ` [PATCH V3 1/8] clk: SPEAr13xx: Fix pcie clock name Mohit Kumar
2014-01-30 10:48 ` [PATCH V3 2/8] SPEAr13xx: Fix static mapping table Mohit Kumar
2014-01-30 10:48 ` [PATCH V3 3/8] SPEAr13xx: defconfig: Update Mohit Kumar
2014-01-30 13:02   ` Arnd Bergmann
2014-01-31  8:50     ` Mohit KUMAR DCG
2014-01-30 10:48 ` [PATCH V3 4/8] phy: Initialize phy core with subsys_initcall Mohit Kumar
2014-01-30 11:43   ` Kishon Vijay Abraham I
2014-01-30 11:52     ` Pratyush Anand
2014-01-30 12:10       ` Kishon Vijay Abraham I
2014-01-30 12:15       ` Pratyush Anand
2014-01-30 12:25         ` Kishon Vijay Abraham I
2014-01-30 12:44       ` Arnd Bergmann
2014-01-31  3:48         ` Pratyush Anand
2014-01-31 15:25           ` Arnd Bergmann [this message]
2014-01-30 10:48 ` [PATCH V3 5/8] ata: ahci platform: Add phy hooks to make it more generic Mohit Kumar
2014-01-30 13:06   ` Arnd Bergmann
2014-01-31  3:52     ` Pratyush Anand
     [not found] ` <cover.1391077731.git.mohit.kumar-qxv4g6HH51o@public.gmane.org>
2014-01-30 10:48   ` [PATCH V3 6/8] SPEAr13xx: Fixup: Move SPEAr1340 SATA platform code to phy driver Mohit Kumar
2014-01-30 10:48     ` Mohit Kumar
2014-01-30 13:21     ` Arnd Bergmann
2014-01-30 13:21       ` Arnd Bergmann
2014-01-31  4:12       ` Pratyush Anand
2014-01-31  4:12         ` Pratyush Anand
2014-01-31 15:27         ` Arnd Bergmann
2014-01-31 15:27           ` Arnd Bergmann
2014-01-30 10:48 ` [PATCH V3 7/8] pcie: SPEAr13xx: Add designware pcie support Mohit Kumar
2014-01-30 13:34   ` Arnd Bergmann
2014-01-30 13:44     ` Arnd Bergmann
2014-01-31  4:44       ` Pratyush Anand
2014-01-31 19:01         ` Arnd Bergmann
2014-02-01  6:32           ` Pratyush Anand
2014-02-03  0:06             ` Jingoo Han
2014-01-31  4:24     ` Pratyush Anand
2014-01-31 15:29       ` Arnd Bergmann
2014-01-30 10:48 ` [PATCH V3 8/8] MAINTAINERS: Add ST SPEAr13xx PCIe driver maintainer Mohit Kumar
2014-02-03  0:08   ` Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201401311625.53846.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=Mohit.KUMAR@st.com \
    --cc=bhelgaas@google.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pratyush.anand@st.com \
    --cc=spear-devel@list.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.