From: Fam Zheng <famz@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Benoît Canet" <benoit.canet@irqsave.net>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] qemu-iotests: Allow caller to disable underscore convertion for qmp
Date: Sat, 1 Feb 2014 23:31:33 +0800 [thread overview]
Message-ID: <20140201153133.GC6756@T430.redhat.com> (raw)
In-Reply-To: <52E90BB6.1070503@redhat.com>
On Wed, 01/29 07:09, Eric Blake wrote:
> On 01/29/2014 01:40 AM, Fam Zheng wrote:
>
> s/convertion/conversion/ in the subject
>
> > QMP command "block_set_io_throttle" expects underscores in parameters
> > instead of dashes: {iops,bps}_{rd,wr,max}.
> >
> > Add optional argument conv_keys (defaults to True, backward compatible),
> > it will be used in IO throttling test case.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > tests/qemu-iotests/iotests.py | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
>
> You know, it might be nice to get the '-'/'_' looseness into QMP itself
> when invoked via JSON strings over the monitor, rather than just the
> testsuite wrapper, since we're already inconsistent in several commands.
> But that's a bigger project for another day.
>
I agree. Let's stick to this now and leave the loosing in QMP for later.
Fam
next prev parent reply other threads:[~2014-02-01 15:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 8:40 [Qemu-devel] [PATCH 0/4] qemu-iotests: Test case for IO throttling Fam Zheng
2014-01-29 8:40 ` [Qemu-devel] [PATCH 1/4] qemu-io: New option "-a" to aio_read and aio_write Fam Zheng
2014-01-29 14:11 ` Stefan Hajnoczi
2014-01-29 15:25 ` Benoît Canet
2014-01-29 15:58 ` Paolo Bonzini
2014-02-01 14:31 ` Fam Zheng
2014-02-02 0:20 ` Paolo Bonzini
2014-02-07 7:47 ` Fam Zheng
2014-01-29 8:40 ` [Qemu-devel] [PATCH 2/4] qemu-iotests: Add VM method qtest_cmd() to iotests.py Fam Zheng
2014-01-29 14:22 ` Stefan Hajnoczi
2014-02-01 15:23 ` Fam Zheng
2014-01-29 8:40 ` [Qemu-devel] [PATCH 3/4] qemu-iotests: Allow caller to disable underscore convertion for qmp Fam Zheng
2014-01-29 14:09 ` Eric Blake
2014-02-01 15:31 ` Fam Zheng [this message]
2014-01-29 14:23 ` Stefan Hajnoczi
2014-01-29 15:29 ` Benoît Canet
2014-01-29 8:40 ` [Qemu-devel] [PATCH 4/4] qemu-iotests: Add 080 for IO throttling Fam Zheng
2014-01-29 14:36 ` Stefan Hajnoczi
2014-01-29 14:45 ` Stefan Hajnoczi
2014-01-29 15:34 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140201153133.GC6756@T430.redhat.com \
--to=famz@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.