From: Josh Triplett <josh@joshtriplett.org>
To: linux-sparse@vger.kernel.org
Cc: Al Viro <viro@ftp.linux.org.uk>
Subject: __attribute__((force)) should not be a storage class
Date: Sat, 1 Feb 2014 10:49:35 -0800 [thread overview]
Message-ID: <20140201184935.GA12321@leaf> (raw)
Commit 3829c4d8b097776e6b3472290a9fae08a705ab7a ("Don't mix storage
class bits with ctype->modifiers while parsing type") in 2009 separated
storage classes from modifiers; in the process, it changed
__attribute__((force)) from a modifier to a storage class. I don't
think it makes sense to have force as a storage class, for one critical
reason: storage classes are mutually exclusive.
$ cat /tmp/test.c
static __attribute__((force)) int *p;
static int q = *p;
$ ./sparse /tmp/test.c
/tmp/test.c:1:28: error: multiple storage classes
Given this, I think force should become a modifier again. Any
objections?
- Josh Triplett
next reply other threads:[~2014-02-01 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-01 18:49 Josh Triplett [this message]
2014-02-02 5:51 ` __attribute__((force)) should not be a storage class Christopher Li
2014-02-02 8:38 ` Josh Triplett
2014-02-27 21:00 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140201184935.GA12321@leaf \
--to=josh@joshtriplett.org \
--cc=linux-sparse@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.