From: Johan Hovold <johan@hovold.com>
To: Ulrich Hahn <uhahn@eanco.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: ..another device for the ftdi_sio driver, 3rd infusion
Date: Sun, 2 Feb 2014 14:15:18 +0100 [thread overview]
Message-ID: <20140202131518.GA27835@localhost> (raw)
In-Reply-To: <1391339456.31834.1@biblenovo>
On Sun, Feb 02, 2014 at 12:10:56PM +0100, Ulrich Hahn wrote:
Please use a more descriptive subject line (which will end up as the
commit log summary), e.g.
"[PATCH v3] USB: ftdi_sio: add Tagsys RFID Reader ids"
Note that the patch version should go in the [PATCH vX] (which will not
show up in the git log).
You should also consider adding a slightly more verbose message in the
body as well (e.g. mentioning which two devices you add support for).
Right now your commit log would be empty.
> Signed-off-by: Ulrich Hahn <uhahn@eanco.de>
>
> diff -ur linux-3.13.1/drivers/usb/serial/ftdi_sio.c linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio.c
> --- linux-3.13.1/drivers/usb/serial/ftdi_sio.c 2014-01-29 14:06:37.000000000 +0100
> +++ linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio.c 2014-02-02 11:57:08.625914749 +0100
> @@ -192,6 +192,8 @@
> { USB_DEVICE(INTERBIOMETRICS_VID, INTERBIOMETRICS_IOBOARD_PID) },
> { USB_DEVICE(INTERBIOMETRICS_VID, INTERBIOMETRICS_MINI_IOBOARD_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_SPROG_II) },
> + { USB_DEVICE(FTDI_VID, FTDI_TAGSYS_LP101_PID) },
> + { USB_DEVICE(FTDI_VID, FTDI_TAGSYS_P200X_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_LENZ_LIUSB_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_XF_632_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_XF_634_PID) },
> Only in linux-3.13.1+tagsys/drivers/usb/serial: ftdi_sio.c.orig
> diff -ur linux-3.13.1/drivers/usb/serial/ftdi_sio_ids.h linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio_ids.h
> --- linux-3.13.1/drivers/usb/serial/ftdi_sio_ids.h 2014-01-29 14:06:37.000000000 +0100
> +++ linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio_ids.h 2014-02-02 11:57:08.629914782 +0100
> @@ -363,6 +363,13 @@
> /* Sprog II (Andrew Crosland's SprogII DCC interface) */
> #define FTDI_SPROG_II 0xF0C8
>
> +/*
> + * Tagsys RFID Readers
> + * survey (two of them) by Ulrich Hahn
No need to include the author in the comment. It will be apparent from
the git log.
> + */
> +#define FTDI_TAGSYS_LP101_PID 0xF0E9 /* Tagsys L-P101 RFID*/
> +#define FTDI_TAGSYS_P200X_PID 0xF0EE /* Tagsys Medio P200x RFID*/
> +
> /* an infrared receiver for user access control with IR tags */
> #define FTDI_PIEGROUP_PID 0xF208 /* Product Id */
Thanks,
Johan
prev parent reply other threads:[~2014-02-02 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 11:10 ..another device for the ftdi_sio driver, 3rd infusion Ulrich Hahn
2014-02-02 13:15 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140202131518.GA27835@localhost \
--to=johan@hovold.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=uhahn@eanco.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.