From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50794)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christoffer.dall@linaro.org>) id 1WA4nq-0004xm-PM
	for qemu-devel@nongnu.org; Sun, 02 Feb 2014 16:42:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <christoffer.dall@linaro.org>) id 1WA4nk-00069P-HU
	for qemu-devel@nongnu.org; Sun, 02 Feb 2014 16:42:10 -0500
Received: from mail-pd0-f177.google.com ([209.85.192.177]:35965)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christoffer.dall@linaro.org>) id 1WA4nk-00066g-BX
	for qemu-devel@nongnu.org; Sun, 02 Feb 2014 16:42:04 -0500
Received: by mail-pd0-f177.google.com with SMTP id x10so6136881pdj.22
	for <qemu-devel@nongnu.org>; Sun, 02 Feb 2014 13:42:03 -0800 (PST)
Date: Sun, 2 Feb 2014 13:42:07 -0800
From: Christoffer Dall <christoffer.dall@linaro.org>
Message-ID: <20140202214207.GA30235@cbox>
References: <1390940890-1868-1-git-send-email-christoffer.dall@linaro.org>
	<CAFEAcA_NXMG8+Vri1_LvOmGeFcB6kh7bYAhEGws=3WtnCFJW8g@mail.gmail.com>
	<CAFEAcA8VLfQ2E5pj4WQ0dv-3apr9ji_5rNKbOn8R9Y_d8pFHyA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA8VLfQ2E5pj4WQ0dv-3apr9ji_5rNKbOn8R9Y_d8pFHyA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/4] Create ARM KVM VGIC with device
	control API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Patch Tracking <patches@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>

On Fri, Jan 31, 2014 at 02:21:42PM +0000, Peter Maydell wrote:
> On 29 January 2014 13:21, Peter Maydell <peter.maydell@linaro.org> wrote:
> > On 28 January 2014 20:28, Christoffer Dall <christoffer.dall@linaro.org> wrote:
> >> This patch series adds generic support for issuing device control
> >> related ioctls and supports creating the ARM KVM-accelerated VGIC using
> >> the device control API while maintaining backwards compatibility for
> >> older kernels.
> >>
> >> Changelogs in the individual patches.
> >
> > Thanks, applied to target-arm.next. Git complains about trailing
> > whitespace in the kernel header patch; dunno if you care about
> > fixing that kind of thing in the kernel upstream.
> 
> I slightly belatedly discovered that these patches break
> the build on aarch64 hosts, because your new kernel defines
> only exist in the arm KVM headers and not the arm64 ones:
> 
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/intc/arm_gic_kvm.c: In
> function 'kvm_arm_gic_realize':
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/intc/arm_gic_kvm.c:141:29:
> error: 'KVM_DEV_ARM_VGIC_GRP_ADDR' undeclared (first use in this
> function)
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/intc/arm_gic_kvm.c:141:29:
> note: each undeclared identifier is reported only once for each
> function it appears in
> 
> I've dropped the patches from target-arm.next. The
> simplest fix is probably to get the arm64 headers to
> also support this API and then resubmit.
> 
Yikes! Yeah, it also breaks the build of arm64 kernels with KVM enabled,
better get this fix upstream fast.  Thanks for spotting it!

-Christoffer