From: Jean Delvare <jdelvare@suse.de>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (adm1021) Convert to use devm_hwmon_device_register_with_groups
Date: Sun, 02 Feb 2014 21:37:12 +0000 [thread overview]
Message-ID: <20140202223712.4e87be7e@endymion.delvare> (raw)
In-Reply-To: <1391362768-27750-1-git-send-email-linux@roeck-us.net>
On Sun, 02 Feb 2014 13:04:47 -0800, Guenter Roeck wrote:
> On 02/02/2014 12:50 PM, Jean Delvare wrote:
> > Hi Guenter,
> >
> > On Sun, 2 Feb 2014 09:39:28 -0800, Guenter Roeck wrote:
> >> + if (IS_ERR(hwmon_dev))
> >> + return PTR_ERR(hwmon_dev);
> >
> > Why not return PTR_ERR_OR_ZERO?
> >
> Hi Jean,
>
> Because I forgot that it exists and only remembered after I sent out the patch ;-).
>
> I'll fix and resubmit. Should I split out the dev = &client->dev change
> into a separate patch ?
No, the lm80 and adm1024 drivers are simple enough, don't bother...
--
Jean Delvare
Suse L3 Support
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2014-02-02 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 17:39 [lm-sensors] [PATCH] hwmon: (adm1021) Convert to use devm_hwmon_device_register_with_groups Guenter Roeck
2014-02-02 20:50 ` Jean Delvare
2014-02-02 21:04 ` Guenter Roeck
2014-02-02 21:37 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140202223712.4e87be7e@endymion.delvare \
--to=jdelvare@suse.de \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.