From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [PATCH 05/17] add 'make cscope' support Date: Mon, 3 Feb 2014 14:25:22 +0100 Message-ID: <20140203132522.GB6832@hawk.usersys.redhat.com> References: <1390321323-1855-1-git-send-email-drjones@redhat.com> <1390321323-1855-6-git-send-email-drjones@redhat.com> <20140202022258.GO3570@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org To: Christoffer Dall Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40958 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbaBCNZg (ORCPT ); Mon, 3 Feb 2014 08:25:36 -0500 Content-Disposition: inline In-Reply-To: <20140202022258.GO3570@cbox> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Feb 01, 2014 at 06:22:58PM -0800, Christoffer Dall wrote: > On Tue, Jan 21, 2014 at 05:21:51PM +0100, Andrew Jones wrote: > > Add a Makefile target to quickly generate arch-specific cscope > > for kvm-unit-tests. Assumes a mostly flat directory structure, > > i.e. uses '-maxdepth 1' in the file search. > > > > Signed-off-by: Andrew Jones > > --- > > Makefile | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index fa95d66386d49..283655957f39f 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -3,7 +3,7 @@ include config.mak > > > > DESTDIR := $(PREFIX)/share/qemu/tests > > > > -.PHONY: arch_clean clean > > +.PHONY: arch_clean clean cscope > > > > #make sure env CFLAGS variable is not used > > CFLAGS = > > @@ -52,3 +52,10 @@ install: > > > > clean: arch_clean > > $(RM) lib/.*.d $(libcflat) $(cflatobjs) > > + > > +cscope: common_dirs = lib > > +cscope: > > + rm -f ./cscope.* > > + find $(TEST_DIR) lib/$(TEST_DIR) $(common_dirs) -maxdepth 1 \ > > + -name "*.[chsS]" -print | sed 's,^\./,,' > ./cscope.files > > shouldn't you use single quotes for the -name pattern to avoid any > substitutions here? > sure, will do