From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Date: Mon, 03 Feb 2014 14:52:05 +0000 Subject: Re: [PATCH v2] Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary prevents Message-Id: <20140203145205.GB2992@phenom.dumpdata.com> List-Id: References: <20140130000831.GJ16825@google.com> <1391160503-11122-1-git-send-email-linux@eikelenboom.it> In-Reply-To: <1391160503-11122-1-git-send-email-linux@eikelenboom.it> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sander Eikelenboom Cc: Bjorn Helgaas , Tony Luck , Dave Airlie , Eiichiro Oiwa , Greg Kroah-Hartman , "linux-kernel @ vger . kernel . org" , "linux-pci @ vger . kernel . org" , linux-ia64@vger.kernel.org On Fri, Jan 31, 2014 at 10:28:22AM +0100, Sander Eikelenboom wrote: > Hi Bjorn / Tony, > > I fixed up ia64 as well and brought it inline again with the x86 code, > but i don't have a ia64 machine, so that part is untested. > Perhaps Tony is able to review/test it ? > > Sander > > > > Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary > prevents it from reading it's own rom. It will get the content of the shadowrom > at C000 instead, which is of the primary VGA card and the driver of the > secondary card will bail out. > > Fix this by checking if the arch code or vga-arbitration has already > determined the vga_default_device, if so only apply the fix to this > primary video device and let the comment reflect this. > > v2: > - Fix pci_fixup_video both in x86 and ia64 > > > Sander Eikelenboom (1): > Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the > primary prevents it from reading it's own rom. It will get the > content of the shadowrom at C000 instead, which is of the > primary VGA card and the driver of the secondary card will bail > out. Your editor mutilated your subject line. It ought to have been just one line. Anyhow, you can also add 'Reviewed-by: Konrad Rzeszutek Wilk > arch/ia64/pci/fixup.c | 24 +++++++++++++----------- > arch/x86/pci/fixup.c | 18 ++++++++++-------- > 2 files changed, 23 insertions(+), 19 deletions(-) > > -- > 1.7.10.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:49352 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbaBCOwX (ORCPT ); Mon, 3 Feb 2014 09:52:23 -0500 Date: Mon, 3 Feb 2014 09:52:05 -0500 From: Konrad Rzeszutek Wilk To: Sander Eikelenboom Cc: Bjorn Helgaas , Tony Luck , Dave Airlie , Eiichiro Oiwa , Greg Kroah-Hartman , "linux-kernel @ vger . kernel . org" , "linux-pci @ vger . kernel . org" , linux-ia64@vger.kernel.org Subject: Re: [PATCH v2] Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary prevents it from reading it's own rom. It will get the content of the shadowrom at C000 instead, which is of the primary VGA card and the driver of the secondary card will bail out. Message-ID: <20140203145205.GB2992@phenom.dumpdata.com> References: <20140130000831.GJ16825@google.com> <1391160503-11122-1-git-send-email-linux@eikelenboom.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1391160503-11122-1-git-send-email-linux@eikelenboom.it> Sender: linux-pci-owner@vger.kernel.org List-ID: On Fri, Jan 31, 2014 at 10:28:22AM +0100, Sander Eikelenboom wrote: > Hi Bjorn / Tony, > > I fixed up ia64 as well and brought it inline again with the x86 code, > but i don't have a ia64 machine, so that part is untested. > Perhaps Tony is able to review/test it ? > > Sander > > > > Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary > prevents it from reading it's own rom. It will get the content of the shadowrom > at C000 instead, which is of the primary VGA card and the driver of the > secondary card will bail out. > > Fix this by checking if the arch code or vga-arbitration has already > determined the vga_default_device, if so only apply the fix to this > primary video device and let the comment reflect this. > > v2: > - Fix pci_fixup_video both in x86 and ia64 > > > Sander Eikelenboom (1): > Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the > primary prevents it from reading it's own rom. It will get the > content of the shadowrom at C000 instead, which is of the > primary VGA card and the driver of the secondary card will bail > out. Your editor mutilated your subject line. It ought to have been just one line. Anyhow, you can also add 'Reviewed-by: Konrad Rzeszutek Wilk > arch/ia64/pci/fixup.c | 24 +++++++++++++----------- > arch/x86/pci/fixup.c | 18 ++++++++++-------- > 2 files changed, 23 insertions(+), 19 deletions(-) > > -- > 1.7.10.4 >