From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 3 Feb 2014 16:06:11 +0100 Subject: [PATCH 09/10] watchdog: xilinx: Add missing binding In-Reply-To: <9c721b89ed2ceb6997809bb3363f852277e67dc2.1391177880.git.michal.simek@xilinx.com> References: <9c721b89ed2ceb6997809bb3363f852277e67dc2.1391177880.git.michal.simek@xilinx.com> Message-ID: <201402031606.11753.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 31 January 2014, Michal Simek wrote: > +Optional properties: > +- clock-frequency : Frequency of clock in Hz > +- xlnx,wdt-enable-once : 0 - Watchdog can be restarted > + 1 - Watchdog can be enabled just once > +- xlnx,wdt-interval : Watchdog timeout interval in 2^ clock cycles, > + is integer from 8 to 31. > + The latter two don't really seem to be xilinx specific, it would be reasonable to have a standard watchdog binding that mandates a common format for them. I'm not sure about the enable-once flag, which seems to just map to the "nowayout" watchdog option that is not a hardware feature at all and should probably be kept as a software setting only, rather than settable through DT. If it is kept, it should have a standard name and get turned into a boolean (present/absent) property rather than a 0/1 integer property. The interval should really be specified in terms of seconds or miliseconds, not in clock cycles. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 09/10] watchdog: xilinx: Add missing binding Date: Mon, 3 Feb 2014 16:06:11 +0100 Message-ID: <201402031606.11753.arnd@arndb.de> References: <9c721b89ed2ceb6997809bb3363f852277e67dc2.1391177880.git.michal.simek@xilinx.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9c721b89ed2ceb6997809bb3363f852277e67dc2.1391177880.git.michal.simek@xilinx.com> Sender: linux-doc-owner@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: Michal Simek , linux-kernel@vger.kernel.org, monstr@monstr.eu, Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , linux-doc@vger.kernel.org, Rob Herring , Rob Landley , Kumar Gala List-Id: devicetree@vger.kernel.org On Friday 31 January 2014, Michal Simek wrote: > +Optional properties: > +- clock-frequency : Frequency of clock in Hz > +- xlnx,wdt-enable-once : 0 - Watchdog can be restarted > + 1 - Watchdog can be enabled just once > +- xlnx,wdt-interval : Watchdog timeout interval in 2^ clock cycles, > + is integer from 8 to 31. > + The latter two don't really seem to be xilinx specific, it would be reasonable to have a standard watchdog binding that mandates a common format for them. I'm not sure about the enable-once flag, which seems to just map to the "nowayout" watchdog option that is not a hardware feature at all and should probably be kept as a software setting only, rather than settable through DT. If it is kept, it should have a standard name and get turned into a boolean (present/absent) property rather than a 0/1 integer property. The interval should really be specified in terms of seconds or miliseconds, not in clock cycles. Arnd