From: Richard Cochran <richardcochran@gmail.com>
To: "Stefan Sørensen" <stefan.sorensen@spectralink.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net:phy:dp83640: Initialize PTP clocks at device init.
Date: Mon, 3 Feb 2014 17:33:32 +0100 [thread overview]
Message-ID: <20140203163332.GA9935@netboy> (raw)
In-Reply-To: <1391438218-21994-1-git-send-email-stefan.sorensen@spectralink.com>
On Mon, Feb 03, 2014 at 03:36:58PM +0100, Stefan Sørensen wrote:
> The trigger and events functionality can be useful even if packet
> timestamping is not used, but the required PTP clock is only enabled
> when packet timestamping is started. This patch moves the clock enable
> to when the interface is configured.
Hm, I vaguely recall that there might have been some reason not enable
the clock too early. (Maybe this was related to multiple PHYs?)
Quickly looking at the code once again, I can't see anything wrong with
this now, but I'll look at it again tomorrow.
Thanks,
Richard
next prev parent reply other threads:[~2014-02-03 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 14:36 [PATCH] net:phy:dp83640: Initialize PTP clocks at device init Stefan Sørensen
2014-02-03 16:33 ` Richard Cochran [this message]
2014-02-04 8:04 ` Richard Cochran
2014-02-05 4:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140203163332.GA9935@netboy \
--to=richardcochran@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stefan.sorensen@spectralink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.