From: Lee Jones <lee.jones@linaro.org>
To: "Opensource [Anthony Olech]" <anthony.olech.opensource@diasemi.com>
Cc: Mark Brown <broonie@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [PATCH V1] fix da9052 volatile register definition ommissions
Date: Mon, 3 Feb 2014 16:47:06 +0000 [thread overview]
Message-ID: <20140203164706.GW13529@lee--X1> (raw)
In-Reply-To: <24DF37198A1E704D9811D8F72B87EB51AD22E658@NB-EX-MBX02.diasemi.com>
> > > Three of the PMIC registers have some bits that are changed
> > > autonomously by the PMIC itself (some time) after being set by some
> > > component driver of the DA9052 PMIC and hence they need to be marked
> > > as volatile so that the regmap API will not cache their values.
> > > Signed-off-by: Anthony Olech <anthony.olech.opensource@diasemi.com>
> > > Signed-off-by: David Dajun Chen <david.chen@diasemi.com>
> > These are not correct.
> > Who authored the patch?
>
> I found the problem when running regression tests for another different problem.
> And according to my testing on a SMDK6410+DA9053EVB the patch is correct!!
I mean the Signed-off-by's are not correct.
They should be in order of the patch submission path.
Who authored the patch initially and what part did David play?
<snip>
> > > REGULATORS - the first change to any DA9052 BUCK voltage will be
> > > actioned, but sebsequent ones will not.
> > Which patch caused the bug?
>
> I will find out when I start rebasing backwards to submit patches to linux-stable!
I'm just wondering where to apply the patch. Either for -fixes or
-next. If the bug has been present for some time, I'll probably just
apply it to my for-next branch.
Also be wary of the $SUBJECT line format when submitting to different
subsystems. You can usually get an idea of what's expected by doing:
`git log --oneline -- drivers/<subsystem>`
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-02-03 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 16:45 [PATCH V1] fix da9052 volatile register definition ommissions Anthony Olech <anthony.olech.opensource@diasemi.com>
2014-02-03 10:29 ` Lee Jones
2014-02-03 16:11 ` Opensource [Anthony Olech]
2014-02-03 16:47 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140203164706.GW13529@lee--X1 \
--to=lee.jones@linaro.org \
--cc=anthony.olech.opensource@diasemi.com \
--cc=broonie@kernel.org \
--cc=david.chen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.