Re: [Qemu-devel] [PATCH V14 00/13] Quorum block filter

["Benoît Canet" <benoit.canet@irqsave.net>]

Le Monday 03 Feb 2014 à 16:10:00 (-0500), Jeff Cody a écrit :
> On Mon, Feb 03, 2014 at 08:11:39PM +0100, Benoît Canet wrote:
> > v14:
> >    Use quorum_report_failure in early failure test suggested by Max [Benoît]
> > 
> > v13:
> >     update copyright date and company legal status
> > 
> > Benoît Canet (13):
> >   quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.
> >   quorum: Create BDRVQuorumState and BlkDriver and do init.
> >   quorum: Add quorum_aio_writev and its dependencies.
> >   blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from
> >     blkverify.
> >   quorum: Add quorum_aio_readv.
> >   quorum: Add quorum mechanism.
> >   quorum: Add quorum_getlength().
> >   quorum: Add quorum_invalidate_cache().
> >   quorum: Add quorum_co_get_block_status.
> >   quorum: Add quorum_co_flush().
> >   quorum: Implement recursive .bdrv_recurse_is_first_non_filter in
> >     quorum.
> >   quorum: Add quorum_open() and quorum_close().
> >   quorum: Add unit test.
> >
> 
> Most of the patches in this series are lacking meaningful commit
> messages - via this series, quorum.c is created, with not much more
> than 1-line commit logs.  Could you please add more details to the
> commit messages?

Ok, I'll do a v16 tomorow.

Best regards

Benoît

> 
> Thanks,
> Jeff
> 
> 
> >  block/Makefile.objs        |   1 +
> >  block/blkverify.c          | 108 +-----
> >  block/quorum.c             | 915 +++++++++++++++++++++++++++++++++++++++++++++
> >  configure                  |  36 ++
> >  docs/qmp/qmp-events.txt    |  33 ++
> >  include/monitor/monitor.h  |   2 +
> >  include/qemu-common.h      |   2 +
> >  monitor.c                  |   2 +
> >  qapi-schema.json           |  21 +-
> >  tests/qemu-iotests/075     |  95 +++++
> >  tests/qemu-iotests/075.out |  34 ++
> >  tests/qemu-iotests/group   |   1 +
> >  util/iov.c                 | 103 +++++
> >  13 files changed, 1246 insertions(+), 107 deletions(-)
> >  create mode 100644 block/quorum.c
> >  create mode 100755 tests/qemu-iotests/075
> >  create mode 100644 tests/qemu-iotests/075.out
> > 
> > -- 
> > 1.8.3.2
> > 
> > 
>