All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: s5p: set automatically clears after resetting Rx FIFO
Date: Tue, 04 Feb 2014 07:33:14 +0100	[thread overview]
Message-ID: <20140204073314.40a499b4@amdc2363> (raw)
In-Reply-To: <20140204145726.2cf093d8@songinha-Samsung-DeskTop-System>

Hi Inha,

> This patch fix the u-boot shell problem on TRATS2 board.
>  - If hold the key while booting is in progress,
>    white spaces are written in u-boot shell.
> 
> Set Automatically clears after resetting Rx FIFO.

Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Tested-by: Lukasz Majewski <l.majewski@samsung.com>

> 
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  drivers/serial/serial_s5p.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/serial/serial_s5p.c b/drivers/serial/serial_s5p.c
> index 89f5d68..98c62b4 100644
> --- a/drivers/serial/serial_s5p.c
> +++ b/drivers/serial/serial_s5p.c
> @@ -100,8 +100,8 @@ static int serial_init_dev(const int dev_index)
>  {
>  	struct s5p_uart *const uart = s5p_get_base_uart(dev_index);
>  
> -	/* enable FIFOs */
> -	writel(0x1, &uart->ufcon);
> +	/* enable FIFOs, auto clear Rx FIFO */
> +	writel(0x3, &uart->ufcon);
>  	writel(0, &uart->umcon);
>  	/* 8N1 */
>  	writel(0x3, &uart->ulcon);



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  reply	other threads:[~2014-02-04  6:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04  5:57 [U-Boot] [PATCH] serial: s5p: set automatically clears after resetting Rx FIFO Inha Song
2014-02-04  6:33 ` Lukasz Majewski [this message]
2014-02-06  0:31 ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140204073314.40a499b4@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.