From: Dan Carpenter <dan.carpenter@oracle.com>
To: SeongJae Park <sj38.park@gmail.com>
Cc: gregkh@linuxfoundation.org, lisa@xenapiadmin.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: bcm: fix pointer-integer size mismatch warnings
Date: Tue, 4 Feb 2014 11:21:10 +0300 [thread overview]
Message-ID: <20140204082110.GG26722@mwanda> (raw)
In-Reply-To: <1391497163-6894-1-git-send-email-sj38.park@gmail.com>
On Tue, Feb 04, 2014 at 03:59:23PM +0900, SeongJae Park wrote:
> Fix the pointer-integer size mismatch warnings below:
> drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
> drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
> integer of different size [-Wint-to-pointer-cast]
> pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
> ^
> drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
> integer of different size [-Wint-to-pointer-cast]
> pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
> ^
> drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
> integer of different size [-Wint-to-pointer-cast]
> pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
> ^
No. You haven't fixed the bug, you've just silenced the warning so now
someone has to spent hours and hours looking for it when it comes time
to write a proper fix. Don't do that.
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-04 8:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 6:59 [PATCH] staging: bcm: fix pointer-integer size mismatch warnings SeongJae Park
2014-02-04 8:21 ` Dan Carpenter [this message]
2014-02-04 8:26 ` SeongJae Park
2014-02-04 8:51 ` Dan Carpenter
2014-02-04 9:00 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204082110.GG26722@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
--cc=sj38.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.