All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] Commit 9e047b982452c633882b486682966c1d97097015 (piix4: add acpi pci hotplug support) seems to break Xen pci-passthrough
Date: Tue, 4 Feb 2014 16:32:19 +0200	[thread overview]
Message-ID: <20140204143219.GA7561@redhat.com> (raw)
In-Reply-To: <1265435524.20140204004608@eikelenboom.it>

On Tue, Feb 04, 2014 at 12:46:08AM +0100, Sander Eikelenboom wrote:
> Grmbll my fat fingers hit the send shortcut too soon by accident ..
> let's try again ..
> 
> Hi Michael,
> 
> A git bisect turned out that commit 9e047b982452c633882b486682966c1d97097015 breaks pci-passthrough on Xen.
> 
> commit 9e047b982452c633882b486682966c1d97097015
> Author: Michael S. Tsirkin <mst@redhat.com>
> Date:   Mon Oct 14 18:01:20 2013 +0300
> 
>     piix4: add acpi pci hotplug support
> 
>     Add support for acpi pci hotplug using the
>     new infrastructure.
>     PIIX4 legacy interface is maintained as is for
>     machine types 1.7 and older.
> 
>     Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> 
> The error is not very verbose :
> 
> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error message from QMP server: Device initialization failed.
> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error message from QMP server: Device initialization failed.
> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error message from QMP server: Device initialization failed.
> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error message from QMP server: Device initialization failed.
> 
> So it seems there is an issue with preserving the legacy interface.


Which machine type is broken?
What's the command line used?
What's the value of has_acpi_build in hw/i386/pc_piix.c?
What happens if you add
-global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off
?

> --
> Sander
> 

  reply	other threads:[~2014-02-04 14:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 23:46 [Qemu-devel] Commit 9e047b982452c633882b486682966c1d97097015 (piix4: add acpi pci hotplug support) seems to break Xen pci-passthrough Sander Eikelenboom
2014-02-04 14:32 ` Michael S. Tsirkin [this message]
2014-02-04 15:07   ` Sander Eikelenboom
2014-02-04 15:07   ` [Qemu-devel] " Sander Eikelenboom
2014-02-04 15:16     ` Igor Mammedov
2014-02-04 15:30     ` Igor Mammedov
2014-02-04 15:49       ` Michael S. Tsirkin
2014-02-04 14:32 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140204143219.GA7561@redhat.com \
    --to=mst@redhat.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=linux@eikelenboom.it \
    --cc=qemu-devel@nongnu.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.