From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH for xen-4.4] libxl: add option for discard
 support to xl disk configuration
Date: Wed, 5 Feb 2014 12:36:23 +0100
Message-ID: <20140205113623.GA24025@aepfle.de>
References: <1391083364-29483-1-git-send-email-olaf@aepfle.de>
	<20140130162558.GA9033@aepfle.de>
	<1391099505.9495.23.camel@kazak.uk.xensource.com>
	<20140130173058.GA12133@aepfle.de>
	<1391530957.6497.56.camel@kazak.uk.xensource.com>
	<52F21C29.8090607@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <52F21C29.8090607@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: anthony.perard@citrix.com, xen-devel@lists.xen.org, Ian.Jackson@eu.citrix.com, Ian Campbell <Ian.Campbell@citrix.com>, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Wed, Feb 05, George Dunlap wrote:

> Well it looks like in order to keep ABI compatibility (which I don't think
> we ever promised), you're introducing this weird hack with overloading a
> putative boolean value with a magic number?

Yes, thats the point. If libxl_device_disk changes then IMO the SONAME
has to change as well. And is 4.4-rc4 is the right time to do that?
Likely not. I'm fine with carry the 4.4 patch to achieve the result, and
put the other version into 4.5.

Olaf