From: Fengguang Wu <fengguang.wu@intel.com>
To: Dinesh Ram <Dinesh.Ram@cern.ch>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: [linuxtv-media:master 224/499] WARNING: Comparing jiffies is almost always wrong; prefer time_after, time_before and friends
Date: Wed, 5 Feb 2014 19:49:41 +0800 [thread overview]
Message-ID: <20140205114941.GC27938@localhost> (raw)
Hi Dinesh,
FYI, there are new warnings show up in
tree: git://linuxtv.org/media_tree.git master
head: c29b8f3149f2916e98fc3b8d6c1df2137d003979
commit: 5173332c1e420d49829bd7e4bc5c83b0205037c5 [224/499] [media] si4713: Modified i2c driver to handle cases where interrupts are not used
:::::: branch date: 2 hours ago
:::::: commit date: 7 weeks ago
scripts/checkpatch.pl 0001-media-si4713-Modified-i2c-driver-to-handle-cases-whe.patch
# many are suggestions rather than must-fix
WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
+ msleep(1);
WARNING: Comparing jiffies is almost always wrong; prefer time_after, time_before and friends
#95: drivers/media/radio/si4713/si4713.c:262:
+ } while (jiffies <= until_jiffies);
WARNING: line over 80 characters
#153: drivers/media/radio/si4713/si4713.c:489:
+ !wait_for_completion_timeout(&sdev->work, usecs_to_jiffies(usecs) + 1))
WARNING: line over 80 characters
#175: drivers/media/radio/si4713/si4713.c:491:
+ "(%s) Device took too much time to answer.\n", __func__);
WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
+ msleep(3);
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
reply other threads:[~2014-02-05 11:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205114941.GC27938@localhost \
--to=fengguang.wu@intel.com \
--cc=Dinesh.Ram@cern.ch \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.