From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB2XR-0004xc-3d for qemu-devel@nongnu.org; Wed, 05 Feb 2014 08:29:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB2XG-0004cb-W9 for qemu-devel@nongnu.org; Wed, 05 Feb 2014 08:29:13 -0500 Received: from paradis.irqsave.net ([62.212.105.220]:49221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB2XG-0004cM-FF for qemu-devel@nongnu.org; Wed, 05 Feb 2014 08:29:02 -0500 Date: Wed, 5 Feb 2014 14:29:01 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140205132901.GD3066@irqsave.net> References: <1391464280-25627-1-git-send-email-benoit.canet@irqsave.net> <1391464280-25627-2-git-send-email-benoit.canet@irqsave.net> <20140204125707.GH3384@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140204125707.GH3384@dhcp-200-207.str.redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V15 01/13] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Le Tuesday 04 Feb 2014 =E0 13:57:07 (+0100), Kevin Wolf a =E9crit : > Am 03.02.2014 um 22:51 hat Beno=EEt Canet geschrieben: > > From: Beno=EEt Canet > >=20 > > Signed-off-by: Benoit Canet > > Reviewed-by: Max Reitz > > --- > > block/Makefile.objs | 1 + > > block/quorum.c | 54 +++++++++++++++++++++++++++++++++++++++++++= ++++++++++ > > 2 files changed, 55 insertions(+) > > create mode 100644 block/quorum.c > >=20 > > diff --git a/block/Makefile.objs b/block/Makefile.objs > > index 4e8c91e..a2650b9 100644 > > --- a/block/Makefile.objs > > +++ b/block/Makefile.objs > > @@ -3,6 +3,7 @@ block-obj-y +=3D qcow2.o qcow2-refcount.o qcow2-clust= er.o qcow2-snapshot.o qcow2-c > > block-obj-y +=3D qed.o qed-gencb.o qed-l2-cache.o qed-table.o qed-cl= uster.o > > block-obj-y +=3D qed-check.o > > block-obj-$(CONFIG_VHDX) +=3D vhdx.o vhdx-endian.o vhdx-log.o > > +block-obj-y +=3D quorum.o > > block-obj-y +=3D parallels.o blkdebug.o blkverify.o > > block-obj-y +=3D snapshot.o qapi.o > > block-obj-$(CONFIG_WIN32) +=3D raw-win32.o win32-aio.o > > diff --git a/block/quorum.c b/block/quorum.c > > new file mode 100644 > > index 0000000..17695d6 > > --- /dev/null > > +++ b/block/quorum.c > > @@ -0,0 +1,54 @@ > > +/* > > + * Quorum Block filter > > + * > > + * Copyright (C) 2012-2014 Nodalink, EURL. > > + * > > + * Author: > > + * Beno=EEt Canet > > + * > > + * Based on the design and code of blkverify.c (Copyright (C) 2010 I= BM, Corp) > > + * and blkmirror.c (Copyright (C) 2011 Red Hat, Inc). >=20 > I think you were planning to respin anyway, so I'll practice my > nitpicking: The file is called mirror.c, not blkmirror.c. It's a reference to blkmirror.c by Marcello Tosati. A patch that was neve= r merged. https://www.google.fr/url?sa=3Dt&rct=3Dj&q=3D&esrc=3Ds&source=3Dweb&cd=3D= 1&cad=3Drja&ved=3D0CCkQFjAA&url=3Dhttps%3A%2F%2Flists.gnu.org%2Farchive%2= Fhtml%2Fqemu-devel%2F2011-05%2Fmsg02521.html&ei=3DFzzyUuOBEeSg0QX9jYCgCg&= usg=3DAFQjCNG6W5qbmITacObTAD4ShOZlxky2bA&bvm=3Dbv.60799247,d.d2k >=20 > > + * > > + * This work is licensed under the terms of the GNU GPL, version 2 o= r later. > > + * See the COPYING file in the top-level directory. > > + */ > > + > > +#include "block/block_int.h" > > + > > +typedef struct QuorumAIOCB QuorumAIOCB; > > + > > +/* Quorum will create one instance of the following structure per op= eration it > > + * performs on its children. > > + * So for each read/write operation coming from the upper layer ther= e will be > > + * $children_count QuorumSingleAIOCB. > > + */ > > +typedef struct QuorumSingleAIOCB { > > + BlockDriverAIOCB *aiocb; >=20 > So this isn't a real AIOCB, but it merely points to one. Perhaps > something like QuorumChildRequest would be a more precise name? >=20 > > + QEMUIOVector qiov; > > + uint8_t *buf; >=20 > The combination of a linear buffer and qiov is unusual. It looks like > there may be a reason for it (otherwise qemu_iovec_clone() wouldn't > exist), but I don't understand it yet at this point. Could hint at a > lack of documentation. >=20 > I might back come to this later in the patch series. >=20 > > + int ret; > > + QuorumAIOCB *parent; > > +} QuorumSingleAIOCB; > > + > > +/* Quorum will use the following structure to track progress of each= read/write > > + * operation received by the upper layer. > > + * This structure hold pointers to the QuorumSingleAIOCB structures = instances > > + * used to do operations on each children and track overall progress= . > > + */ > > +struct QuorumAIOCB { > > + BlockDriverAIOCB common; > > + > > + /* Request metadata */ > > + uint64_t sector_num; > > + int nb_sectors; > > + > > + QEMUIOVector *qiov; /* calling IOV */ > > + > > + QuorumSingleAIOCB *aios; /* individual AIOs */ > > + int count; /* number of completed AIOCB */ > > + int success_count; /* number of successfully completed = AIOCB */ > > + bool *finished; /* completion signal for cancel */ > > + > > + bool is_read; > > + int vote_ret; > > +}; >=20 > Kevin