All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"x86@kernel.org" <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, apic: clean up handling of boot_cpu_physical_apicid in boot process
Date: Wed, 5 Feb 2014 11:40:25 -0500	[thread overview]
Message-ID: <20140205164025.GG6042@redhat.com> (raw)
In-Reply-To: <52D7A8F0.70807@jp.fujitsu.com>

On Thu, Jan 16, 2014 at 06:40:00PM +0900, HATAYAMA Daisuke wrote:

[..]
> diff --git a/arch/x86/include/asm/mpspec.h b/arch/x86/include/asm/mpspec.h
> index 3142a94..724853f 100644
> --- a/arch/x86/include/asm/mpspec.h
> +++ b/arch/x86/include/asm/mpspec.h
> @@ -47,6 +47,7 @@ extern int mp_bus_id_to_type[MAX_MP_BUSSES];
>  extern DECLARE_BITMAP(mp_bus_not_pci, MAX_MP_BUSSES);
>  
>  extern unsigned int boot_cpu_physical_apicid;
> +extern unsigned int bios_bsp_physical_apicid;

I think put some comments here to explain clearly what is
boot_cpu_physical_apicid and what is bios_bsp_physical_apicid and what's
the difference. So that anybody making use of these variables or changing
code understands the difference better.

Thanks
Vivek

      parent reply	other threads:[~2014-02-05 16:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16  9:40 [PATCH] x86, apic: clean up handling of boot_cpu_physical_apicid in boot process HATAYAMA Daisuke
2014-01-26  4:02 ` David Rientjes
2014-01-27  2:55   ` HATAYAMA Daisuke
2014-01-27 23:58     ` David Rientjes
2014-02-05 16:38     ` Vivek Goyal
2014-02-05 17:09       ` Vivek Goyal
2014-02-05 16:40 ` Vivek Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140205164025.GG6042@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=d.hatayama@jp.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.