From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [pkg-perl infra V4 6/9] perl: remove useless patch
Date: Wed, 5 Feb 2014 17:03:09 +0100 [thread overview]
Message-ID: <20140205170309.3a7da08e@skate> (raw)
In-Reply-To: <1391608380-23240-7-git-send-email-francois.perrad@gadz.org>
Dear Francois Perrad,
On Wed, 5 Feb 2014 14:52:57 +0100, Francois Perrad wrote:
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/perl/perl-fix-Module-Build.patch | 16 ----------------
> 1 file changed, 16 deletions(-)
> delete mode 100644 package/perl/perl-fix-Module-Build.patch
It would be good to indicate in the commit log why the patch was
useless.
Sorry to bother you so much about commit logs, but they are *really*
important. I can't tell you the number of times I look at the git
commit logs in the history of Buildroot to understand why such or such
choice was made. So I really want to have good commit logs, and a
commit log such as "remove useless patch" is not a good commit log, as
it doesn't explain *why* the change was made.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-05 16:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 13:52 [Buildroot] [pkg-perl infra V4 0/9] a package infrastructure for Perl/CPAN modules Francois Perrad
2014-02-05 13:52 ` [Buildroot] [pkg-perl infra V4 1/9] pkg-perl: refactor and rename PERL5LIB Francois Perrad
2014-02-05 15:55 ` Thomas Petazzoni
2014-02-05 19:44 ` François Perrad
2014-02-05 19:48 ` Thomas Petazzoni
2014-02-06 6:29 ` Arnout Vandecappelle
2014-02-06 11:30 ` François Perrad
2014-02-05 13:52 ` [Buildroot] [pkg-perl infra V4 2/9] pkg-perl: new infrastructure Francois Perrad
2014-02-06 7:11 ` Arnout Vandecappelle
2014-02-06 13:41 ` [Buildroot] [UNSURE]Re: " François Perrad
2014-02-05 13:52 ` [Buildroot] [pkg-perl infra V4 3/9] scancpan: a new script Francois Perrad
2014-02-05 13:52 ` [Buildroot] [pkg-perl infra V4 4/9] host-perl-xml-parser: rename and refactor with perl infrastructure Francois Perrad
2014-02-05 15:58 ` Thomas Petazzoni
2014-02-05 13:52 ` [Buildroot] [pkg-perl infra V4 5/9] host-perl-module-build: new package Francois Perrad
2014-02-05 13:52 ` [Buildroot] [pkg-perl infra V4 6/9] perl: remove useless patch Francois Perrad
2014-02-05 16:03 ` Thomas Petazzoni [this message]
2014-02-05 19:46 ` François Perrad
2014-02-05 19:51 ` Thomas Petazzoni
2014-02-05 13:52 ` [Buildroot] [pkg-perl infra V4 7/9] manual: adding packages perl Francois Perrad
2014-02-05 13:52 ` [Buildroot] [pkg-perl infra V4 8/9] cpanminus: remove it Francois Perrad
2014-02-05 13:53 ` [Buildroot] [pkg-perl infra V4 9/9] qemu: add a Config.in.host Francois Perrad
2014-02-05 16:04 ` Thomas Petazzoni
2014-02-05 19:48 ` François Perrad
2014-02-06 17:16 ` Arnout Vandecappelle
2014-02-06 20:46 ` Frank Hunleth
2014-02-06 21:37 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205170309.3a7da08e@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.