All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH 0/2] init: option parsing fixes
Date: Wed, 5 Feb 2014 10:11:15 -0700	[thread overview]
Message-ID: <20140205171115.GE27534@kernel.dk> (raw)
In-Reply-To: <1391520431-21732-1-git-send-email-stefanha@redhat.com>

On Tue, Feb 04 2014, Stefan Hajnoczi wrote:
> Patch 1 changes --minimal from optional_argument to no_argument.  There seems
> to be no reason why optional_argument was used (the option doesn't use optarg).
> 
> Patch 2 fixes a segfault when --output-format is used without an argument.
> 
> Stefan Hajnoczi (2):
>   init: --minimal does not take an optional argument
>   init: log error on missing --output-format argument
> 
>  init.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Thanks, applied both!

-- 
Jens Axboe



      parent reply	other threads:[~2014-02-05 17:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04 13:27 [PATCH 0/2] init: option parsing fixes Stefan Hajnoczi
2014-02-04 13:27 ` [PATCH 1/2] init: --minimal does not take an optional argument Stefan Hajnoczi
2014-02-04 13:27 ` [PATCH 2/2] init: log error on missing --output-format argument Stefan Hajnoczi
2014-02-05 17:11 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140205171115.GE27534@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.