All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: Aravind Batni <aravindbr@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH v2] ti-csl: new recipe providing CSL for TI-KeyStone2 devices
Date: Wed, 5 Feb 2014 14:53:17 -0500	[thread overview]
Message-ID: <20140205195317.GW18784@edge> (raw)
In-Reply-To: <1391624082-26580-1-git-send-email-aravindbr@ti.com>

On Wed, Feb 05, 2014 at 01:14:42PM -0500, Aravind Batni wrote:
> -This package provides chip support library interface files
> 
> Signed-off-by: Aravind Batni <aravindbr@ti.com>
> ---
> * grouped SRC_URI and SRCREV together
> * Modified do_install to copy the needed files only instead of copy everything
>   delete unwanted files.
> ---
> ---
>  meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb |   22 ++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb
> 
> diff --git a/meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb b/meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb
> new file mode 100644
> index 0000000..37f7937
> --- /dev/null
> +++ b/meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb
> @@ -0,0 +1,22 @@
> +DESCRIPTION = "TI CSL"
> +LICENSE = "TI BSD"
> +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=5857833e20836213677fac33f9aded21"
> +
> +COMPATIBLE_MACHINE = "keystone-evm"

Do you want to relax it to entire "keystone" family, not just EVM?


> +ALLOW_EMPTY_${PN} = "1"
> +
> +PR = "r0"
> +BRANCH="master"
> +SRC_URI = "git://git.ti.com/keystone-rtos/common-csl-ip.git;protocol=git;branch=${BRANCH}"
> +# commit ID corresponds to DEV.CSL_KEYSTONE2.02.00.00.17
> +SRCREV = "f6f90144c14e1ee783c4b893b52e54830be8166e" 
> +S = "${WORKDIR}/git"
> +
> +do_install () {
> +    cd ${S}

do_install already operates from within ${S}. If you need to control it 
further, you can pass it to find commands below, instead of "."

Either way it's rather nit-picking, along with SRCREV order...


> +    install -d ${D}${includedir}/ti/csl
> +    find . -name "*.h" -type f | xargs -I {} cp --parents {} ${D}${includedir}/ti/csl 
> +    find ./src/ip/serdes_sb/V0 -name "*.c" -type f | xargs -I {} cp --parents {} ${D}${includedir}/ti/csl/src/ip/serdes_sb/V0
> +}
> +
> -- 
> 1.7.9.5
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


  parent reply	other threads:[~2014-02-05 19:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 18:14 [PATCH v2] ti-csl: new recipe providing CSL for TI-KeyStone2 devices Aravind Batni
2014-02-05 18:17 ` Maupin, Chase
2014-02-05 19:53 ` Denys Dmytriyenko [this message]
2014-02-11 21:17   ` Aravind Batni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140205195317.GW18784@edge \
    --to=denys@ti.com \
    --cc=aravindbr@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.