All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Engelmayer <cengelma-RbZlAiThDcE@public.gmane.org>
To: Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] spi: orion: Remove unused pointer in orion_spi_write_read()
Date: Wed, 5 Feb 2014 22:23:01 +0100	[thread overview]
Message-ID: <20140205222301.14fbb441@spike> (raw)

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

Remove unused devdata pointer 'orion_spi' in function orion_spi_write_read().

Detected by Coverity: CID 1077860.

Signed-off-by: Christian Engelmayer <cengelma-RbZlAiThDcE@public.gmane.org>
---
 drivers/spi/spi-orion.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c
index 7f2121f..75871d4 100644
--- a/drivers/spi/spi-orion.c
+++ b/drivers/spi/spi-orion.c
@@ -260,11 +260,9 @@ orion_spi_write_read_16bit(struct spi_device *spi,
 static unsigned int
 orion_spi_write_read(struct spi_device *spi, struct spi_transfer *xfer)
 {
-	struct orion_spi *orion_spi;
 	unsigned int count;
 	int word_len;
 
-	orion_spi = spi_master_get_devdata(spi->master);
 	word_len = spi->bits_per_word;
 	count = xfer->len;
 
-- 
1.8.3.2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2014-02-05 21:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 21:23 Christian Engelmayer [this message]
2014-02-05 21:31 ` [PATCH] spi: orion: Remove unused pointer in orion_spi_write_read() Mark Brown
     [not found]   ` <20140205213116.GA12659-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-02-05 21:54     ` Christian Engelmayer
2014-02-05 22:12       ` Mark Brown
     [not found]         ` <20140205221226.GJ32298-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-02-05 23:30           ` Christian Engelmayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140205222301.14fbb441@spike \
    --to=cengelma-rbzlaithdce@public.gmane.org \
    --cc=broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.