From: Jens Axboe <axboe@kernel.dk>
To: Grant Grundler <grundler@chromium.org>
Cc: FIO_list <fio@vger.kernel.org>,
Puthikorn Voravootivat <puthik@chromium.org>
Subject: Re: Rip out verify_backlog support?
Date: Wed, 5 Feb 2014 15:30:52 -0700 [thread overview]
Message-ID: <20140205223052.GF20626@kernel.dk> (raw)
In-Reply-To: <CANEJEGt5neHeCc-wnDDyFWY7S_AyxzKjaOj09DXR08oRjF+Dow@mail.gmail.com>
On Wed, Feb 05 2014, Grant Grundler wrote:
> > It does - that's the log_io_piece() mechanism. The writer will generate
> > on, and verify will read those and verify. We just have to ensure that
> > it is correct in the way that it is logged. The alternative would be to
> > rely purely on the generator rollback, and for that you would then need
> > some specific notification on how far the reader could proceed, if async
> > verify_backlog is used.
>
> Yes - I was referring to the "rely purely on generator rollback".
>
> Once log_io_piece() is called, the verify code assumes the IO is
> complete...which isn't true if log_io_piece() is used to record "order
> issued".
Right, we'd need to ensure the state is accurately known to the
verifier.
--
Jens Axboe
next prev parent reply other threads:[~2014-02-05 22:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 18:43 Rip out verify_backlog support? Grant Grundler
2014-02-05 19:32 ` Jens Axboe
2014-02-05 19:44 ` Grant Grundler
2014-02-05 19:53 ` Jens Axboe
2014-02-05 21:03 ` Grant Grundler
2014-02-05 21:28 ` Jens Axboe
2014-02-05 21:47 ` Grant Grundler
2014-02-05 22:30 ` Jens Axboe [this message]
2014-02-06 3:34 ` Jens Axboe
2014-02-06 18:58 ` Puthikorn Voravootivat
2014-02-06 19:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205223052.GF20626@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=grundler@chromium.org \
--cc=puthik@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.