From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] backlight: add PWM dependencies Date: Thu, 6 Feb 2014 17:08:05 +0100 Message-ID: <201402061708.05845.arnd@arndb.de> References: <1391518634-6472-1-git-send-email-linus.walleij@linaro.org> <000101cf2307$97a3c770$c6eb5650$%han@samsung.com> <000001cf230c$60ec1ca0$22c455e0$%han@samsung.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.17.8]:59201 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbaBFQIM (ORCPT ); Thu, 6 Feb 2014 11:08:12 -0500 In-Reply-To: <000001cf230c$60ec1ca0$22c455e0$%han@samsung.com> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Jingoo Han Cc: 'Linus Walleij' , 'Thierry Reding' , 'Russell King - ARM Linux' , 'Eric Miao' , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org On Thursday 06 February 2014, Jingoo Han wrote: > In the case of "CONFIG_HAVE_PWM=y && CONFIG_PWM=n", it makes > the problem. > > The HAVE_PWM symbol is only for legacy platforms that provide > the PWM API without using the generic framework. PXA looks to > use the generic PWM framework. Then, how about removing > "select HAVE_PWM" from PXA as below? > I think this is correct, but we may need additional patches. I notice that INPUT_MAX8997_HAPTIC and INPUT_PWM_BEEPER have a dependency on HAVE_PWM at the moment, so those two drivers become impossible to select after your change. There is also one use of HAVE_PWM outside of PXA, for ARCH_LPC32XX. This one seems to have the same problem. Finally, I have recently encountered a couple of drivers (BACKLIGHT_LM3630A, BACKLIGHT_LP855X, BACKLIGHT_LP8788) that use the PWM interfaces but are missing a 'depends on PWM'. This is strictly speaking a different problem, but we could try to solve it at the same time. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 6 Feb 2014 17:08:05 +0100 Subject: [PATCH] backlight: add PWM dependencies In-Reply-To: <000001cf230c$60ec1ca0$22c455e0$%han@samsung.com> References: <1391518634-6472-1-git-send-email-linus.walleij@linaro.org> <000101cf2307$97a3c770$c6eb5650$%han@samsung.com> <000001cf230c$60ec1ca0$22c455e0$%han@samsung.com> Message-ID: <201402061708.05845.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 06 February 2014, Jingoo Han wrote: > In the case of "CONFIG_HAVE_PWM=y && CONFIG_PWM=n", it makes > the problem. > > The HAVE_PWM symbol is only for legacy platforms that provide > the PWM API without using the generic framework. PXA looks to > use the generic PWM framework. Then, how about removing > "select HAVE_PWM" from PXA as below? > I think this is correct, but we may need additional patches. I notice that INPUT_MAX8997_HAPTIC and INPUT_PWM_BEEPER have a dependency on HAVE_PWM at the moment, so those two drivers become impossible to select after your change. There is also one use of HAVE_PWM outside of PXA, for ARCH_LPC32XX. This one seems to have the same problem. Finally, I have recently encountered a couple of drivers (BACKLIGHT_LM3630A, BACKLIGHT_LP855X, BACKLIGHT_LP8788) that use the PWM interfaces but are missing a 'depends on PWM'. This is strictly speaking a different problem, but we could try to solve it at the same time. Arnd