All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Lasse Makholm <lasse.makholm@gmail.com>
Subject: Re: [PATCH 1/2] t0003: do not chdir the whole test process
Date: Thu, 6 Feb 2014 11:45:21 -0800	[thread overview]
Message-ID: <20140206194521.GU30398@google.com> (raw)
In-Reply-To: <1391712033-9443-1-git-send-email-gitster@pobox.com>

Junio C Hamano wrote:

> Moving to some other directory and letting the remainder of the test
> pieces to expect that they start there is a bad practice.

I agree with the above, and I like the patch...

>                                                            The test
> that contains chdir itself may fail (or by mistake skipped via the
> GIT_SKIP_TESTS mechanism) in which case the remainder may operate on
> files in unexpected places.

... but this logic seems wrong.  I don't think we've ever supported
setup tests failing or being skipped in the past.

Thanks,
Jonathan

  parent reply	other threads:[~2014-02-06 19:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06 12:48 attr.c doesn't honor --work-tree option Lasse Makholm
2014-02-06 17:54 ` Junio C Hamano
2014-02-06 18:40   ` [PATCH 1/2] t0003: do not chdir the whole test process Junio C Hamano
2014-02-06 18:40     ` [PATCH 2/2] check-attr: move to the top of working tree when in non-bare repository Junio C Hamano
2014-02-06 19:53       ` Jonathan Nieder
2014-02-06 20:17         ` Jonathan Nieder
2014-02-06 20:32           ` Junio C Hamano
2014-02-16 11:15           ` Michael Haggerty
2014-02-06 19:45     ` Jonathan Nieder [this message]
2014-02-06 20:25       ` [PATCH 1/2] t0003: do not chdir the whole test process Junio C Hamano
2014-02-06 20:31         ` Jonathan Nieder
2014-02-06 21:26           ` Junio C Hamano
2014-02-10 12:57   ` attr.c doesn't honor --work-tree option Lasse Makholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140206194521.GU30398@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=lasse.makholm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.