Re: [PATCH] linux-2.6.18/xencons: generalize use of add_preferred_console()

[Olaf Hering <olaf@aepfle.de>]

On Fri, Dec 13, Jan Beulich wrote:

> Changeset 762:a070228ac76e ("add hvc compatibility mode to xencons"
> added this call just for the HVC case, without giving any reason why
> HVC would be special in this regard. Use the call for all cases.

> +++ b/drivers/xen/console/console.c
> @@ -236,6 +234,8 @@ static int __init xen_console_init(void)
>  
>  	wbuf = alloc_bootmem(wbuf_size);
>  
> +	if (!is_initial_xendomain())
> +		add_preferred_console(kcons_info.name, xc_num, NULL);
>  	register_console(&kcons_info);

Why is dom0 special in this case anyway? At least with SLE12, when Xen
is booted with 'console=com1 com1=115200' and the kernel is booted
without any console= or xencons=, kcons_info.index is still -1 and as a
result xvc-1 is registered as name for xvc0. This confuses systemd
because kernel name and console name do not match, so login via serial
is not possible.

When add_preferred_console is called uncondtionally the login on serial
works as expected.


Olaf