Re: [meta-qt5][PATCH 1/2] nativesdk-qtbase: add nativesdk version of qtbase necessary for SDK tools

[Denys Dmytriyenko <denys@ti.com>]

On Fri, Feb 07, 2014 at 01:15:34AM +0100, Nicolas Dechesne wrote:
> hi,
> 
> On Tue, Nov 26, 2013 at 2:47 AM, Denys Dmytriyenko <denis@denix.org> wrote:
> > +do_install() {
> > +    # Fix install paths for all
> > +    find -name "Makefile*" | xargs sed -i "s,(INSTALL_ROOT)${STAGING_DIR_NATIVE}${STAGING_DIR_NATIVE},(INSTALL_ROOT)${STAGING_DIR_NATIVE},g"
> > +
> > +    # switch back the proper qmake
> > +    rm ${B}/bin/qmake
> > +    mv ${B}/bin/qmake-real ${B}/bin/qmake
> > +
> > +    oe_runmake install INSTALL_ROOT=${D}
> > +
> > +    # for modules which are still using syncqt and call qtPrepareTool(QMAKE_SYNCQT, syncqt)
> > +    # e.g. qt3d, qtwayland
> > +    ln -sf syncqt.pl ${D}${OE_QMAKE_PATH_QT_BINS}/syncqt
> > +}
> 
> about this patch (which was merged already), i am wondering if this is
> okay to do something like above. basically in the do_install task we
> are 'corrupting' the output of the do_compile task. Here we remove
> ${B}/bin/qmake for example. so if the do_install fails for whatever
> reason, it will never be able to resume properly, since ${B} is no
> longer what it should be after a legitimate do_compile. i was
> debugging some weird build issues, and I am wondering if my problem
> doesn't come from that...

Hmm, never thought of it like that. I guess there are couple options:

1. Make the qmake switch above at the end of do_compile instead
2. Keep it in do_install, but manipulate ${D} instead of ${B} by installing 
${B}/qmake-real into ${D}/qmake

-- 
Denys