All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: kwolf@redhat.com, Jeff Cody <jcody@redhat.com>,
	qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes
Date: Fri, 7 Feb 2014 09:14:50 +0530	[thread overview]
Message-ID: <20140207034450.GB3787@in.ibm.com> (raw)
In-Reply-To: <20140205192535.GA3440@irqsave.net>

On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote:
> Le Tuesday 04 Feb 2014 à 14:26:58 (-0500), Jeff Cody a écrit :
> >  
> > +static void qemu_gluster_parse_flags(int bdrv_flags, int *open_flags)
> > +{
> > +    assert(open_flags != NULL);
> > +
> > +    *open_flags |= O_BINARY;
> > +
> > +    if (bdrv_flags & BDRV_O_RDWR) {
> > +        *open_flags |= O_RDWR;
> > +    } else {
> > +        *open_flags |= O_RDONLY;
> > +    }
> > +
> > +    if ((bdrv_flags & BDRV_O_NOCACHE)) {
> > +        *open_flags |= O_DIRECT;
> > +    }
> > +}
> 
> I saw the enable-O_SYNC option here.
> http://www.gluster.org/community/documentation/index.php/Translators/performance
> Why the gluster driver does not allow to enable O_SYNC ?

I am not aware of any option in QEMU (like cache= etc) that will force
block driver (like gluster) to use O_SYNC. Do other drivers use O_SYNC ?

Turning off write-behind for the entire gluster volume isn't an option ?

Regards,
Bharata.

  reply	other threads:[~2014-02-07  3:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04 19:26 [Qemu-devel] [PATCH 0/2] block: add support for gluster reopen Jeff Cody
2014-02-04 19:26 ` [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes Jeff Cody
2014-02-05 19:25   ` Benoît Canet
2014-02-07  3:44     ` Bharata B Rao [this message]
2014-02-07 14:22       ` Benoît Canet
2014-02-07 15:27         ` Bharata B Rao
2014-02-07 15:57           ` Jeff Cody
2014-02-10 17:49             ` Benoît Canet
2014-02-07 15:59           ` Benoît Canet
2014-02-14 14:12   ` Stefan Hajnoczi
2014-02-14 14:44     ` Jeff Cody
2014-02-14 14:21   ` Stefan Hajnoczi
2014-02-14 14:41     ` Jeff Cody
2014-02-14 15:38       ` Stefan Hajnoczi
2014-02-14 16:20         ` Jeff Cody
2014-02-14 16:28       ` Kevin Wolf
2014-02-04 19:26 ` [Qemu-devel] [PATCH 2/2] block: gluster - add reopen support Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140207034450.GB3787@in.ibm.com \
    --to=bharata@linux.vnet.ibm.com \
    --cc=benoit.canet@irqsave.net \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.