From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751496AbaBGDN7 (ORCPT ); Thu, 6 Feb 2014 22:13:59 -0500 Received: from m12-15.163.com ([220.181.12.15]:42549 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751051AbaBGDN5 (ORCPT ); Thu, 6 Feb 2014 22:13:57 -0500 Date: Fri, 7 Feb 2014 11:13:07 +0800 From: "=?utf-8?B?bGl1anVubGlhbmdfbGps?=" To: "=?utf-8?B?Sm9lIFBlcmNoZXM=?=" Cc: "=?utf-8?B?ZGF2ZW0=?=" , "=?utf-8?B?aG9ybXM=?=" , "=?utf-8?B?cm9taWV1?=" , "=?utf-8?B?Z3JlZ2to?=" , "=?utf-8?B?bmV0ZGV2?=" , "=?utf-8?B?bGludXgtdXNi?=" , "=?utf-8?B?bGludXgta2VybmVs?=" , "=?utf-8?B?c3VuaGVjaGVuZw==?=" References: <1390898200-9925-1-git-send-email-liujunliang_ljl@163.com>, <1390899572.20150.97.camel@joe-AO722> Subject: =?utf-8?B?UmU6IFJlOiBbUEFUQ0hdIFVTQjJORVQgOiBTUjk4MDAgOiBPbmUgY2hpcCBVU0IyLjAgVVNCMk5FVCBTUjk4MDBEZXZpY2UgRHJpdmVyIFN1cHBvcnQ=?= Message-ID: <201402071113053122628@163.com> X-mailer: Foxmail 6, 15, 201, 22 [cn] Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-CM-TRANSID: D8CowECZDUA_T_RSiTeuAQ--.487S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7KryUtw4fAr4fGw4rAryrWFg_yoW8XrWkpa s7KF1Fyws7Wr13tw1avrs5G3s8Xr4UG343Way5KrWFvF1DZr93Gan8W34jg3W7KryrAw1Y vw4jvay7uws5urJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07je385UUUUU= X-Originating-IP: [119.123.180.76] X-CM-SenderInfo: xolxy3pqolt0hjboyzi6rwjhhfrp/1tbiLwQqX1EAJxK96QABsv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s173EEYQ009553 Dear Joe ： I'm sorry that I reply so late, because I have just spent new chinese year. I will resubmit SR9800 Driver today. Thanks a lot. 2014-02-07 liujunliang_ljl 发件人： Joe Perches 发送时间： 2014-01-28 16:59:38 收件人： liujunliang_ljl 抄送： davem; horms; romieu; gregkh; netdev; linux-usb; linux-kernel; sunhecheng 主题： Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device Driver Support On Tue, 2014-01-28 at 16:36 +0800, liujunliang_ljl@163.com wrote: > From: Liu Junliang trivial comments... > diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c [] > +static int sr_rx_fixup(struct usbnet *dev, struct sk_buff *skb) > +{ [] > + if (size != ((~header >> 16) & 0x07ff)) { > + netdev_err(dev->net, > + "sr_rx_fixup() Bad Header Length\n"); printks with embedded functions names are generally better using "%s: ", __func__ netdev_err(dev->net, "%s: Bad header length\n", __func__); [] > + netdev_err(dev->net, > + "sr_rx_fixup() Bad RX Length %d\n", size); etc. > + if (skb->len != offset) { > + netdev_err(dev->net, "sr_rx_fixup() Bad SKB Length %d\n", > + skb->len); etc. [] > +static inline int sr9800_set_default_mode(struct usbnet *dev) > +{ rather a big function to inline [] > + if (ret < 0) { > + netdev_dbg(dev->net, "Write IPG,IPG1,IPG2 failed: %d", ret); missing newline terminations > + netdev_dbg(dev->net, "RX_CTL is 0x%04x after all initializations", > + rx_ctl); etc... {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "=?utf-8?B?bGl1anVubGlhbmdfbGps?=" Subject: =?utf-8?B?UmU6IFJlOiBbUEFUQ0hdIFVTQjJORVQgOiBTUjk4MDAgOiBPbmUgY2hpcCBVU0IyLjAgVVNCMk5FVCBTUjk4MDBEZXZpY2UgRHJpdmVyIFN1cHBvcnQ=?= Date: Fri, 7 Feb 2014 11:13:07 +0800 Message-ID: <201402071113053122628@163.com> References: <1390898200-9925-1-git-send-email-liujunliang_ljl@163.com>, <1390899572.20150.97.camel@joe-AO722> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "=?utf-8?B?ZGF2ZW0=?=" , "=?utf-8?B?aG9ybXM=?=" , "=?utf-8?B?cm9taWV1?=" , "=?utf-8?B?Z3JlZ2to?=" , "=?utf-8?B?bmV0ZGV2?=" , "=?utf-8?B?bGludXgtdXNi?=" , "=?utf-8?B?bGludXgta2VybmVs?=" , "=?utf-8?B?c3VuaGVjaGVuZw==?=" To: "=?utf-8?B?Sm9lIFBlcmNoZXM=?=" Return-path: Received: from m12-15.163.com ([220.181.12.15]:42549 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751051AbaBGDN5 (ORCPT ); Thu, 6 Feb 2014 22:13:57 -0500 Sender: netdev-owner@vger.kernel.org List-ID: RGVhciBKb2Ug77yaDQoNCgkJSSdtIHNvcnJ5IHRoYXQgSSByZXBseSBzbyBsYXRlLCBiZWNhdXNl IEkgaGF2ZSBqdXN0IHNwZW50IG5ldyBjaGluZXNlIHllYXIuDQoNCgkJSSB3aWxsIHJlc3VibWl0 IFNSOTgwMCBEcml2ZXIgdG9kYXkuDQoNCgkJVGhhbmtzIGEgbG90Lg0KDQoNCjIwMTQtMDItMDcg DQoNCg0KDQpsaXVqdW5saWFuZ19samwgDQoNCg0KDQrlj5Hku7bkurrvvJogSm9lIFBlcmNoZXMg DQrlj5HpgIHml7bpl7TvvJogMjAxNC0wMS0yOCAgMTY6NTk6MzggDQrmlLbku7bkurrvvJogbGl1 anVubGlhbmdfbGpsIA0K5oqE6YCB77yaIGRhdmVtOyBob3Jtczsgcm9taWV1OyBncmVna2g7IG5l dGRldjsgbGludXgtdXNiOyBsaW51eC1rZXJuZWw7IHN1bmhlY2hlbmcgDQrkuLvpopjvvJogUmU6 IFtQQVRDSF0gVVNCMk5FVCA6IFNSOTgwMCA6IE9uZSBjaGlwIFVTQjIuMCBVU0IyTkVUIFNSOTgw MERldmljZSBEcml2ZXIgU3VwcG9ydCANCiANCk9uIFR1ZSwgMjAxNC0wMS0yOCBhdCAxNjozNiAr MDgwMCwgbGl1anVubGlhbmdfbGpsQDE2My5jb20gd3JvdGU6DQo+IEZyb206IExpdSBKdW5saWFu ZyA8bGl1anVubGlhbmdfbGpsQDE2My5jb20+DQp0cml2aWFsIGNvbW1lbnRzLi4uDQo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL25ldC91c2Ivc3I5ODAwLmMgYi9kcml2ZXJzL25ldC91c2Ivc3I5ODAw LmMNCltdDQo+ICtzdGF0aWMgaW50IHNyX3J4X2ZpeHVwKHN0cnVjdCB1c2JuZXQgKmRldiwgc3Ry dWN0IHNrX2J1ZmYgKnNrYikNCj4gK3sNCltdDQo+ICsgaWYgKHNpemUgIT0gKCh+aGVhZGVyID4+ IDE2KSAmIDB4MDdmZikpIHsNCj4gKyBuZXRkZXZfZXJyKGRldi0+bmV0LA0KPiArICAgICJzcl9y eF9maXh1cCgpIEJhZCBIZWFkZXIgTGVuZ3RoXG4iKTsNCnByaW50a3Mgd2l0aCBlbWJlZGRlZCBm dW5jdGlvbnMgbmFtZXMgYXJlDQpnZW5lcmFsbHkgYmV0dGVyIHVzaW5nICIlczogIiwgX19mdW5j X18NCm5ldGRldl9lcnIoZGV2LT5uZXQsICIlczogQmFkIGhlYWRlciBsZW5ndGhcbiIsDQogICBf X2Z1bmNfXyk7DQpbXQ0KPiArIG5ldGRldl9lcnIoZGV2LT5uZXQsDQo+ICsgICAgInNyX3J4X2Zp eHVwKCkgQmFkIFJYIExlbmd0aCAlZFxuIiwgc2l6ZSk7DQpldGMuDQo+ICsgaWYgKHNrYi0+bGVu ICE9IG9mZnNldCkgew0KPiArIG5ldGRldl9lcnIoZGV2LT5uZXQsICJzcl9yeF9maXh1cCgpIEJh ZCBTS0IgTGVuZ3RoICVkXG4iLA0KPiArICAgIHNrYi0+bGVuKTsNCmV0Yy4NCltdDQo+ICtzdGF0 aWMgaW5saW5lIGludCBzcjk4MDBfc2V0X2RlZmF1bHRfbW9kZShzdHJ1Y3QgdXNibmV0ICpkZXYp DQo+ICt7DQpyYXRoZXIgYSBiaWcgZnVuY3Rpb24gdG8gaW5saW5lDQpbXQ0KPiArIGlmIChyZXQg PCAwKSB7DQo+ICsgbmV0ZGV2X2RiZyhkZXYtPm5ldCwgIldyaXRlIElQRyxJUEcxLElQRzIgZmFp bGVkOiAlZCIsIHJldCk7DQptaXNzaW5nIG5ld2xpbmUgdGVybWluYXRpb25zDQo+ICsgbmV0ZGV2 X2RiZyhkZXYtPm5ldCwgIlJYX0NUTCBpcyAweCUwNHggYWZ0ZXIgYWxsIGluaXRpYWxpemF0aW9u cyIsDQo+ICsgICAgcnhfY3RsKTsNCmV0Yy4uLg0K