From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33119)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WBmKE-0007GY-LN
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 09:22:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WBmK8-0004Mu-K1
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 09:22:38 -0500
Received: from paradis.irqsave.net ([62.212.105.220]:49388)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WBmK8-0004Mg-Af
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 09:22:32 -0500
Date: Fri, 7 Feb 2014 15:22:29 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140207142229.GA3081@irqsave.net>
References: <cover.1391541706.git.jcody@redhat.com>
	<925f4c0a62291c070991d1b3e75a770de986a686.1391541706.git.jcody@redhat.com>
	<20140205192535.GA3440@irqsave.net>
	<20140207034450.GB3787@in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20140207034450.GB3787@in.ibm.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements,
 state storage changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>
Cc: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>, kwolf@redhat.com, Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com

Le Friday 07 Feb 2014 =E0 09:14:50 (+0530), Bharata B Rao a =E9crit :
> On Wed, Feb 05, 2014 at 08:25:36PM +0100, Beno=EEt Canet wrote:
> > Le Tuesday 04 Feb 2014 =E0 14:26:58 (-0500), Jeff Cody a =E9crit :
> > > =20
> > > +static void qemu_gluster_parse_flags(int bdrv_flags, int *open_fla=
gs)
> > > +{
> > > +    assert(open_flags !=3D NULL);
> > > +
> > > +    *open_flags |=3D O_BINARY;
> > > +
> > > +    if (bdrv_flags & BDRV_O_RDWR) {
> > > +        *open_flags |=3D O_RDWR;
> > > +    } else {
> > > +        *open_flags |=3D O_RDONLY;
> > > +    }
> > > +
> > > +    if ((bdrv_flags & BDRV_O_NOCACHE)) {
> > > +        *open_flags |=3D O_DIRECT;
> > > +    }
> > > +}
> >=20
> > I saw the enable-O_SYNC option here.
> > http://www.gluster.org/community/documentation/index.php/Translators/=
performance
> > Why the gluster driver does not allow to enable O_SYNC ?
>=20
> I am not aware of any option in QEMU (like cache=3D etc) that will forc=
e
> block driver (like gluster) to use O_SYNC. Do other drivers use O_SYNC =
?

[,cache=3Dwritethrough|writeback|none|directsync|unsafe][

I think writethough is O_SYNC and directsync is O_DIRECT|O_SYNC.

Best regards

Beno=EEt

>=20
> Turning off write-behind for the entire gluster volume isn't an option =
?
>=20
> Regards,
> Bharata.
>=20