Re: [PATCH 08/13] net: Move prototype declaration to include/net/ipx.h from net/ipx/ipx_route.c

[Josh Triplett <josh@joshtriplett.org>]

On Sun, Feb 09, 2014 at 01:32:10AM +0530, Rashika Kheria wrote:
> Move prototype definition of function to header file include/net/ipx.h
> from net/ipx/ipx_route.c because they are used by more than one file.
> 
> This eliminates the following warning from net/ipx/af_ipx.c:
> net/ipx/af_ipx.c:193:23: warning: no previous prototype for ‘ipxitf_find_using_net’ [-Wmissing-prototypes]
> net/ipx/af_ipx.c:577:5: warning: no previous prototype for ‘ipxitf_send’ [-Wmissing-prototypes]
> net/ipx/af_ipx.c:1219:8: warning: no previous prototype for ‘ipx_cksum’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  include/net/ipx.h   |    3 +++
>  net/ipx/ipx_route.c |    4 ----
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/include/net/ipx.h b/include/net/ipx.h
> index 9e9e354..75466ac 100644
> --- a/include/net/ipx.h
> +++ b/include/net/ipx.h
> @@ -140,6 +140,9 @@ static __inline__ void ipxitf_hold(struct ipx_interface *intrfc)
>  }
>  
>  void ipxitf_down(struct ipx_interface *intrfc);
> +struct ipx_interface *ipxitf_find_using_net(__be32 net);
> +int ipxitf_send(struct ipx_interface *intrfc, struct sk_buff *skb, char *node);
> +__be16 ipx_cksum(struct ipxhdr *packet, int length);
>  
>  static __inline__ void ipxitf_put(struct ipx_interface *intrfc)
>  {
> diff --git a/net/ipx/ipx_route.c b/net/ipx/ipx_route.c
> index 30f4519..c1f0318 100644
> --- a/net/ipx/ipx_route.c
> +++ b/net/ipx/ipx_route.c
> @@ -20,15 +20,11 @@ DEFINE_RWLOCK(ipx_routes_lock);
>  
>  extern struct ipx_interface *ipx_internal_net;
>  
> -extern __be16 ipx_cksum(struct ipxhdr *packet, int length);
>  extern struct ipx_interface *ipxitf_find_using_net(__be32 net);
>  extern int ipxitf_demux_socket(struct ipx_interface *intrfc,
>  			       struct sk_buff *skb, int copy);
>  extern int ipxitf_demux_socket(struct ipx_interface *intrfc,
>  			       struct sk_buff *skb, int copy);
> -extern int ipxitf_send(struct ipx_interface *intrfc, struct sk_buff *skb,
> -		       char *node);
> -extern struct ipx_interface *ipxitf_find_using_net(__be32 net);
>  
>  struct ipx_route *ipxrtr_lookup(__be32 net)
>  {
> -- 
> 1.7.9.5
>