From: Andi Kleen <ak@linux.intel.com>
To: Stefani Seibold <stefani@seibold.net>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
x86@kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, aarcange@redhat.com, john.stultz@linaro.org,
luto@amacapital.net, xemul@parallels.com, gorcunov@openvz.org,
andriy.shevchenko@linux.intel.com,
Martin.Runge@rohde-schwarz.com, Andreas.Brief@rohde-schwarz.com
Subject: Re: [PATCH v13 8/9] Add 32 bit VDSO time support for 32 bit kernel
Date: Sun, 9 Feb 2014 02:05:36 -0800 [thread overview]
Message-ID: <20140209100536.GM12219@tassilo.jf.intel.com> (raw)
In-Reply-To: <1391933453.1014.20.camel@wall-e.seibold.net>
> EBX is a reserved as the base register when compiling with -fPIC.
> Otherwise it get a "error: can't find a register in class 'BREG' while
> reloading 'asm'".
In this case you have to dwarf annotate the push/pop
>
> > Also I if this calls syscall.S:__kernel_vsyscall it clobbers more registers
> > (ecx at least?) and you need to describe that to gcc with a +
>
> Sine ECX is in use as the second parameter it is still marked as
> clobbered.
No input parameters are not clobbered.
> I think it should word... As i know a system call will preserve all
> register expect the EAX, which is marked as in and out for this asm()
> directive.
Yes the syscall does, but the vsyscall stub does not (for the !0x80 case)
> This is due the -m32 compilation, i will get a log of
> "warning: integer constant is too large for 'unsigned long' type",
> because a unsigned long is only 32 bit.
Don't explain it to me, put it into a comment.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2014-02-09 10:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 21:29 [PATCH v13 0/9] Add 32 bit VDSO time function support stefani
2014-02-08 21:29 ` [PATCH v13 1/9] Make vsyscall_gtod_data handling x86 generic stefani
2014-02-08 21:29 ` [PATCH v13 2/9] Add new func _install_special_mapping() to mmap.c stefani
2014-02-08 21:29 ` [PATCH v13 3/9] revamp vclock_gettime.c stefani
2014-02-08 21:29 ` [PATCH v13 4/9] vclock_gettime.c __vdso_clock_gettime cleanup stefani
2014-02-08 21:29 ` [PATCH v13 5/9] replace VVAR(vsyscall_gtod_data) by gtod macro stefani
2014-02-08 21:29 ` [PATCH v13 6/9] cleanup __vdso_gettimeofday stefani
2014-02-08 21:29 ` [PATCH v13 7/9] introduce VVAR marco for vdso32 stefani
2014-02-08 21:29 ` [PATCH v13 8/9] Add 32 bit VDSO time support for 32 bit kernel stefani
2014-02-09 5:22 ` Andi Kleen
2014-02-09 7:21 ` Andi Kleen
2014-02-09 8:15 ` Stefani Seibold
2014-02-09 8:10 ` Stefani Seibold
2014-02-09 10:05 ` Andi Kleen [this message]
2014-02-09 10:43 ` Stefani Seibold
2014-02-09 11:45 ` Stefani Seibold
2014-02-09 20:11 ` H. Peter Anvin
2014-02-08 21:29 ` [PATCH v13 9/9] Add 32 bit VDSO time support for 64 " stefani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140209100536.GM12219@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=Andreas.Brief@rohde-schwarz.com \
--cc=Martin.Runge@rohde-schwarz.com \
--cc=aarcange@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gorcunov@openvz.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=stefani@seibold.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.