All of lore.kernel.org
 help / color / mirror / Atom feed
From: Till Maas <opensource-44rtNO6TQJOzQB+pC5nmwQ@public.gmane.org>
To: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Cryptroot-ask.sh: Use variables consistently
Date: Sun, 9 Feb 2014 16:19:57 +0100	[thread overview]
Message-ID: <20140209151957.GE12401@genius.invalid> (raw)
In-Reply-To: <52F77EFA.2070600-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Sun, Feb 09, 2014 at 02:13:30PM +0100, Harald Hoyer wrote:
> On 02/09/2014 09:08 AM, Till Maas wrote:
> > - Always use $luksname instead of sometimes $2
> > - define $asked_file instead of using the same path twice
> > ---
> >  modules.d/90crypt/cryptroot-ask.sh | 14 ++++++++------
> >  1 file changed, 8 insertions(+), 6 deletions(-)
> > 
> 
> Thanks! Pushed.

Thank you. Unluckily the patch did not apply as intended since someone
else did some similar changes since I created the patch. Please apply
the patch I just sent to the mailing list to clean this up. Sorry for
the trouble.

Regards
Till

  parent reply	other threads:[~2014-02-09 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-09  8:08 [PATCH] Cryptroot-ask.sh: Use variables consistently Till Maas
     [not found] ` <1391933322-17308-1-git-send-email-opensource-44rtNO6TQJOzQB+pC5nmwQ@public.gmane.org>
2014-02-09 13:13   ` Harald Hoyer
     [not found]     ` <52F77EFA.2070600-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-09 15:19       ` Till Maas [this message]
2014-02-09 19:37   ` Alexander Tsoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140209151957.GE12401@genius.invalid \
    --to=opensource-44rtno6tqjozqb+pc5nmwq@public.gmane.org \
    --cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.