All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] Question about Coding-Style
Date: Mon, 10 Feb 2014 10:58:49 +0100	[thread overview]
Message-ID: <20140210105849.198999db@lilith> (raw)
In-Reply-To: <20140204150732.GC7049@bill-the-cat>

Hi Tom,

On Tue, 4 Feb 2014 10:07:32 -0500, Tom Rini <trini@ti.com> wrote:

> On Tue, Feb 04, 2014 at 04:02:56PM +0100, Stefano Babic wrote:
> > Hi Hannes,
> > 
> > On 04/02/2014 15:50, Hannes Petermaier wrote:
> [snip]
> > > Another thing is linewrapping of output strings, to obey to the rules i
> > > have to format the string as following:
> > > 
> > > if (i2c_probe(TPS65217_CHIP_PM)) {
> > > 	printf("PMIC chip (0x%02x) not present! skipping" \
> > > 		"further configuration.\n", TPS65217_CHIP_PM);
> > > 	return;
> > > }
> > > 
> > > But this makes it impossible to grep the code in case of an error.
> > 
> > You must combine a more complicate grep, maybe with the -A (after
> > context) option or using a regexp. However, this is not a reason to
> > break the rule.
> 
> Strings are the reason to break the rule and we have checkpatch patched
> (mostly?) to not complain.  It's even true in the kernel.

Hmm... Last time I checked,

	"abc"
	"def"

Is a valid C string, and does not require a backslash. Do I miss
something?

Amicalement,
-- 
Albert.

  reply	other threads:[~2014-02-10  9:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04 12:50 [U-Boot] Question about Coding-Style Hannes Petermaier
2014-02-04 14:14 ` Stefano Babic
2014-02-04 14:18   ` Michael Trimarchi
2014-02-04 14:50   ` Hannes Petermaier
2014-02-04 15:02     ` Stefano Babic
2014-02-04 15:07       ` Tom Rini
2014-02-10  9:58         ` Albert ARIBAUD [this message]
2014-02-10 10:16           ` Chris Moore
2014-02-10 10:54             ` Albert ARIBAUD
2014-02-10 18:27             ` Wolfgang Denk
2014-02-04 20:32     ` Wolfgang Denk
2014-02-04 15:02 ` Tom Rini
2014-02-04 20:20 ` Wolfgang Denk
2014-02-04 22:03 ` Scott Wood
2014-02-12 13:21   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140210105849.198999db@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.