From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dave Chinner <david@fromorbit.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs.git fixes for -rc2
Date: Mon, 10 Feb 2014 11:17:59 +0000 [thread overview]
Message-ID: <20140210111759.GD18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20140210104747.GV13997@dastard>
On Mon, Feb 10, 2014 at 09:47:47PM +1100, Dave Chinner wrote:
> and the updated pos value on O_APPEND writes is never folded back
> into ppos.
Not true. Check generic_file_buffered_write() and generic_file_direct_write()
- that's where it's normally stored into iocb->ki_pos (via *ppos). And yes,
I agree that the damn thing is obfuscated to hell and back - other commits
in my local tree kill 'ppos' arguments of __generic_file_aio_write() and
generic_file_buffered_write() (equal to &iocb->ki_pos for all call sites),
which makes it a bit easier to keep track of. Will push that part of
queue into vfs.git#iov_iter today...
next prev parent reply other threads:[~2014-02-10 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 23:36 [git pull] vfs.git fixes for -rc2 Al Viro
2014-02-10 10:47 ` Dave Chinner
2014-02-10 10:52 ` Christoph Hellwig
2014-02-10 11:16 ` Geert Uytterhoeven
2014-02-10 11:17 ` Dave Chinner
2014-02-10 11:17 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-12 16:16 Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210111759.GD18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.