All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] libtorrent: disable on ARC arch
Date: Mon, 10 Feb 2014 13:53:18 +0100	[thread overview]
Message-ID: <20140210135318.4fc79cae@skate> (raw)
In-Reply-To: <1392035982-26386-1-git-send-email-anton.kolesov@synopsys.com>

Dear Anton Kolesov,

On Mon, 10 Feb 2014 16:39:42 +0400, Anton Kolesov wrote:
> Is that better?

This "Is that better?" shouldn't be part of the commit log. Instead, it
should be below the "---" sign.

> 
> Libtorrent has dependencies on atomic operations. However ARC GCC doesn't
> implement those at the moment so package should be disabled. Rtorrent
> depends on libtorrent.
> 
> This fixes:
> http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/
> 
> Signed-off-by: Anton Kolesov <anton.kolesov@synopsys.com>
> ---
>  package/libtorrent/Config.in | 3 +++
>  package/rtorrent/Config.in   | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/package/libtorrent/Config.in b/package/libtorrent/Config.in
> index a7e358d..a21bf95 100644
> --- a/package/libtorrent/Config.in
> +++ b/package/libtorrent/Config.in
> @@ -2,6 +2,8 @@ config BR2_PACKAGE_LIBTORRENT
>  	bool "libtorrent"
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	# ARC GCC doesn't support atomic instructions required by this lib
> +	depends on !BR2_arc
>  	select BR2_PACKAGE_LIBSIGC
>  	help
>  	  BitTorrent library written in C++ for *nix
> @@ -10,3 +12,4 @@ config BR2_PACKAGE_LIBTORRENT
>  
>  comment "libtorrent needs a toolchain w/ C++, threads"
>  	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_arc
> diff --git a/package/rtorrent/Config.in b/package/rtorrent/Config.in
> index 0f39a92..f2dc47b 100644
> --- a/package/rtorrent/Config.in
> +++ b/package/rtorrent/Config.in
> @@ -17,3 +17,4 @@ config BR2_PACKAGE_RTORRENT
>  comment "rtorrent needs a toolchain w/ C++, threads, wchar"
>  	depends on BR2_USE_MMU
>  	depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS)
> +	depends on !BR2_arc

It should also be propagated as a dependency of the
BR2_PACKAGE_RTORRENT option itself, so that this package cannot be
selected on ARC.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-02-10 12:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10 11:27 [Buildroot] [PATCH] libtorrent: disable on ARC arch Anton Kolesov
2014-02-10 11:33 ` Thomas De Schampheleire
2014-02-10 12:17   ` Thomas Petazzoni
2014-02-10 12:39     ` [Buildroot] [PATCH v2] " Anton Kolesov
2014-02-10 12:53       ` Thomas Petazzoni [this message]
2014-02-10 14:09         ` [Buildroot] [PATCH v3] " Anton Kolesov
2014-02-10 14:24           ` Thomas Petazzoni
2014-02-10 14:42           ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140210135318.4fc79cae@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.