From: Lee Jones <lee.jones@linaro.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Laszlo Papp <lpapp@kde.org>,
Linus Walleij <linus.walleij@linaro.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mfd: MAX6650/6651 support
Date: Mon, 10 Feb 2014 15:56:28 +0000 [thread overview]
Message-ID: <20140210155628.GA26997@lee--X1> (raw)
In-Reply-To: <CAK9yfHyBRvr5fDCiCsNWV2q83PDsY=b1H3ocmk4pQ96m5m0cHg@mail.gmail.com>
> >> > +#include <linux/device.h>
> >> > +#include <linux/mfd/core.h>
> >> > +#include <linux/module.h>
> >> > +#include <linux/i2c.h>
> >>
> >> Please arrange these alphabetically.
> >
> > Why?
>
> 1. It makes it easier to avoid adding duplicate includes.
> 2. Code looks more ordered/organized.
> 3. Prevents further clean up patches arranging them so :)
I wouldn't accept any patches doing such worthless things. ;)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-02-10 15:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 11:33 [PATCH v2] mfd: MAX6650/6651 support Laszlo Papp
2014-02-09 19:50 ` Laszlo Papp
2014-02-10 7:37 ` Krzysztof Kozlowski
2014-02-10 7:46 ` Laszlo Papp
2014-02-10 12:02 ` Sachin Kamat
2014-02-10 12:21 ` Lee Jones
2014-02-10 15:20 ` Sachin Kamat
2014-02-10 15:56 ` Lee Jones [this message]
2014-02-10 18:36 ` Laszlo Papp
[not found] ` <CAOMwXhNmjehcd+aiWGuKs7CijheXXngsXTHMfG9SDLpHO=KaPw@mail.gmail.com>
2014-02-10 15:22 ` Sachin Kamat
2014-02-11 10:10 ` Laszlo Papp
2014-02-11 11:14 ` Sachin Kamat
2014-02-11 11:39 ` Laszlo Papp
2014-02-11 11:42 ` Sachin Kamat
2014-02-11 12:23 ` Laszlo Papp
2014-02-11 12:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210155628.GA26997@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpapp@kde.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.