From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Aring Subject: Re: 6lowpan: lockless tx queue of routing netlink device Date: Mon, 10 Feb 2014 18:33:18 +0100 Message-ID: <20140210173314.GA12594@omega> References: <20140209102047.GA14770@omega> <1391949707.10160.130.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Eric Dumazet Return-path: Content-Disposition: inline In-Reply-To: <1391949707.10160.130.camel-XN9IlZ5yJG9HTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-zigbee-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: netdev.vger.kernel.org Hi Eric, On Sun, Feb 09, 2014 at 04:41:47AM -0800, Eric Dumazet wrote: > > Please try the following fix, thanks for this report ! > > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c > index 48b25c0af4d0..069af33013c4 100644 > --- a/net/ieee802154/6lowpan.c > +++ b/net/ieee802154/6lowpan.c > @@ -533,7 +533,27 @@ static struct header_ops lowpan_header_ops = { > .create = lowpan_header_create, > }; > > +static struct lock_class_key lowpan_tx_busylock; > +static struct lock_class_key lowpan_netdev_xmit_lock_key; > + > +static void lowpan_set_lockdep_class_one(struct net_device *dev, > + struct netdev_queue *txq, > + void *_unused) > +{ > + lockdep_set_class(&txq->_xmit_lock, > + &lowpan_netdev_xmit_lock_key); > +} > + > + > +static int lowpan_dev_init(struct net_device *dev) > +{ > + netdev_for_each_tx_queue(dev, lowpan_set_lockdep_class_one, NULL); > + dev->qdisc_tx_busylock = &lowpan_tx_busylock; > + return 0; > +} > + > static const struct net_device_ops lowpan_netdev_ops = { > + .ndo_init = lowpan_dev_init, > .ndo_start_xmit = lowpan_xmit, > .ndo_set_mac_address = lowpan_set_address, > }; thanks, this fixed the issue. What we should do as next? Should I create a patch for this or do you want to make a patch? - Alex ------------------------------------------------------------------------------ Android™ apps run on BlackBerry®10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk