From: Peter Zijlstra <peterz@infradead.org>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-rt-users@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andreas Platschek <platschek@ict.tuwien.ac.at>
Subject: Re: allow preemption in check_task_state
Date: Mon, 10 Feb 2014 18:38:33 +0100 [thread overview]
Message-ID: <20140210173833.GQ9987@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140210171712.GA17517@opentech.at>
On Mon, Feb 10, 2014 at 06:17:12PM +0100, Nicholas Mc Guire wrote:
> maybe I'm missing/missunderstanding something here but
> pi_unlock -> arch_spin_unlock is a full mb()
Nope, arch_spin_unlock() on x86 is a single add[wb] without LOCK prefix.
The lock and unlock primitives are in general specified to have ACQUIRE
resp. RELEASE semantics.
See Documentation/memory-barriers.txt for far too much head-hurting
details.
next prev parent reply other threads:[~2014-02-10 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 15:38 allow preemption in check_task_state Nicholas Mc Guire
2014-02-10 16:11 ` Steven Rostedt
2014-02-10 17:17 ` Nicholas Mc Guire
2014-02-10 17:38 ` Peter Zijlstra [this message]
2014-02-10 18:12 ` Nicholas Mc Guire
2014-02-10 18:16 ` Peter Zijlstra
2014-02-10 18:45 ` Nicholas Mc Guire
2014-02-10 17:52 ` Steven Rostedt
2014-02-10 18:13 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210173833.GQ9987@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=der.herr@hofr.at \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=platschek@ict.tuwien.ac.at \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.