From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Mon, 10 Feb 2014 18:01:59 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: (max6650) Rename the device ids to contain the hwmon suffix Message-Id: <20140210180159.GF26997@lee--X1> List-Id: References: <1392045953-26596-1-git-send-email-lpapp@kde.org> <20140210160842.GB26997@lee--X1> <20140210173811.04ba5964@endymion.delvare> <20140210165853.GD26997@lee--X1> <20140210184323.456e921c@endymion.delvare> In-Reply-To: <20140210184323.456e921c@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jean Delvare Cc: Laszlo Papp , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org PiA+ID4gPiBNaWdodCBiZSB3b3J0aCB0YWtpbmcgdGhlIG9wcG9ydHVuaXR5IHRvIHN3YXAgb3V0 IHRoZXNlIG1hZ2ljIG51bWJlcnMKPiA+ID4gPiBub3cuCj4gPiA+IAo+ID4gPiBUaGVyZSdzIG5v dGhpbmcgbWFnaWMgYWJvdXQgdGhlbSwgdGhleSB0ZWxsIHRoZSBkcml2ZXIgaG93IG1hbnkgZmFu cwo+ID4gPiBlYWNoIGRldmljZSBzdXBwb3J0cy4gSWYgeW91IGRvbid0IHBhc3MgdGhlbSBhcyBk cml2ZXJfZGF0YSB5b3UnbGwgaGF2ZQo+ID4gPiB0byBkZXJpdmUgdGhlbSBmcm9tIHRoZSBkZXZp Y2UgbmFtZSBpbiB0aGUgcHJvYmUgZnVuY3Rpb24uCj4gPiAKPiA+IFRoZXkncmUgbWFnaWMgaW4g dGhhdCB0aGV5J3JlIG5vdCBlYXNpbHkgaWRlbnRpZmlhYmxlLiBJbiB0aGUgZmV3Cj4gPiBtb21l bnRzIHRoYXQgSSBsb29rZWQgYXQgdGhlIHBhdGNoIEkgYXNzdW1lZCB0aGV5IHdlcmUgZGV2aWNl Cj4gPiBJRHMuIFRoZXkgc2hvdWxkIGJlIGNsZWFybHkgZGVmaW5lZC4KPiAKPiBUaGV5IGNvdWxk IGhhdmUgYmVlbiBkZXZpY2UgSURzLCBzb21lIGRyaXZlcnMgZG8gdGhhdCwgYW5kIHRoYXQgd291 bGQKPiBoYXZlIGJlZW4gZXF1YWxseSBmaW5lLiBkcml2ZXJfZGF0YSBjYW4gYmUgYW55dGhpbmcu IEJlc3QgdGhpbmcgdG8gZG8KPiBpcyB0byBkb2N1bWVudCBpdCByaWdodCBhYm92ZSB0aGUgZGV2 aWNlIGlkIGFycmF5IGlmIHlvdSByZWFsbHkgZmluZCBpdAo+IGNvbmZ1c2luZyAoSSBkb24ndC4p IEkgZG9uJ3Qga25vdyB3aGF0IGVsc2UgZXhhY3RseSB5b3UgaGFkIGluIG1pbmQsCj4gYnV0ICNk ZWZpbmluZyBGT1VSX0ZBTlMgYXMgNCBhbmQgT05FX0ZBTiBhcyAxIGFuZCB1c2luZyB0aGF0IGRv ZXNuJ3QKPiBzdHJpa2UgbWUgYXMgdGhlIGJlc3QgY29kaW5nIHByYWN0aWNlLgoKT24gdGhlIGNv bnRyYXJ5LiBQZXJoYXBzIHRoZSBub21lbmNsYXR1cmUgY2FuIGJlIHdvcmtlZCBvbiBhIGxpdHRs ZSwKYnV0IGlmIEkgc2F3IHRoZSBhZm9yZW1lbnRpb25lZCBkZWZpbmVzIEkgd291bGQgaGF2ZSBr bm93biBpbnN0YW50bHkKd2hhdCB3YXMgYmVpbmcgZGVmaW5lZCB3aXRob3V0IHNlYXJjaGluZyBm b3IgY28tbG9jYXRlZCBjb21tZW50cy4gVGh1cwplbGV2YXRpbmcgdGhlIHJlcXVpcmVtZW50IGZv ciBtZSB0byBldmVuIG1lbnRpb24gaXQuIEV2ZW4gd2hlbiB3ZQp1c2UgdGhlIC5kYXRhIGVsZW1l bnQgZm9yIHZlcnkgc2ltcGxlIGluZm9ybWF0aW9uIHN1Y2ggYXMgZGV2aWNlIElEcwp3ZSBkbyBz byB3aXRoIGEgI2RlZmluZS4KCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWljcm9lbGVjdHJvbmlj cyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBm b3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0tc2Vuc29ycyBt YWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMubG0tc2Vu c29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753529AbaBJSCJ (ORCPT ); Mon, 10 Feb 2014 13:02:09 -0500 Received: from mail-wg0-f41.google.com ([74.125.82.41]:38765 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752295AbaBJSCF (ORCPT ); Mon, 10 Feb 2014 13:02:05 -0500 Date: Mon, 10 Feb 2014 18:01:59 +0000 From: Lee Jones To: Jean Delvare Cc: Laszlo Papp , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org Subject: Re: [PATCH] hwmon: (max6650) Rename the device ids to contain the hwmon suffix Message-ID: <20140210180159.GF26997@lee--X1> References: <1392045953-26596-1-git-send-email-lpapp@kde.org> <20140210160842.GB26997@lee--X1> <20140210173811.04ba5964@endymion.delvare> <20140210165853.GD26997@lee--X1> <20140210184323.456e921c@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140210184323.456e921c@endymion.delvare> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > > Might be worth taking the opportunity to swap out these magic numbers > > > > now. > > > > > > There's nothing magic about them, they tell the driver how many fans > > > each device supports. If you don't pass them as driver_data you'll have > > > to derive them from the device name in the probe function. > > > > They're magic in that they're not easily identifiable. In the few > > moments that I looked at the patch I assumed they were device > > IDs. They should be clearly defined. > > They could have been device IDs, some drivers do that, and that would > have been equally fine. driver_data can be anything. Best thing to do > is to document it right above the device id array if you really find it > confusing (I don't.) I don't know what else exactly you had in mind, > but #defining FOUR_FANS as 4 and ONE_FAN as 1 and using that doesn't > strike me as the best coding practice. On the contrary. Perhaps the nomenclature can be worked on a little, but if I saw the aforementioned defines I would have known instantly what was being defined without searching for co-located comments. Thus elevating the requirement for me to even mention it. Even when we use the .data element for very simple information such as device IDs we do so with a #define. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog