All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH driver-core-next] kernfs: fix hash calculation in kernfs_rename_ns()
Date: Mon, 10 Feb 2014 16:01:41 -0800	[thread overview]
Message-ID: <20140211000141.GA30793@kroah.com> (raw)
In-Reply-To: <20140210225709.GH25350@mtj.dyndns.org>

On Mon, Feb 10, 2014 at 05:57:09PM -0500, Tejun Heo wrote:
> 3eef34ad7dc3 ("kernfs: implement kernfs_get_parent(),
> kernfs_name/path() and friends") restructured kernfs_rename_ns() such
> that new name assignment happens under kernfs_rename_lock;
> unfortunately, it mistakenly passed NULL to kernfs_name_hash() to
> calculate the new hash if the name hasn't changed, which can lead to
> oops.
> 
> Fix it by using kn->name and kn->ns when calculating the new hash.

Now applied, thanks.

Also, can you look into the merge of 3.14-rc2 into the driver-core-next
branch?  There are some conflicts in the kernfs code due to the lockdep
changes that I couldn't easily verify I got right, so I didn't do the
merge.  Could you give me a diff of the merge for me to work off of?

thanks,

greg k-h

  reply	other threads:[~2014-02-11  0:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10 22:57 [PATCH driver-core-next] kernfs: fix hash calculation in kernfs_rename_ns() Tejun Heo
2014-02-11  0:01 ` Greg Kroah-Hartman [this message]
2014-02-11  0:39   ` Tejun Heo
2014-02-11 16:56     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140211000141.GA30793@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.