From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 1/3] mfd: Add realtek USB card reader driver Date: Tue, 11 Feb 2014 10:02:33 +0000 Message-ID: <20140211100233.GK32042@lee--X1> References: <1391697307-23457-1-git-send-email-rogerable@realtek.com> <1391697307-23457-2-git-send-email-rogerable@realtek.com> <20140210113054.GE21522@lee--X1> <52F9F012.8030302@realtek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <52F9F012.8030302@realtek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Roger Cc: Ulf Hansson , Samuel Ortiz , Alex Dubov , Greg Kroah-Hartman , driverdev-devel@linuxdriverproject.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn, Chris Ball , Dan Carpenter , Maxim Levitsky List-Id: linux-mmc@vger.kernel.org T24gVHVlLCAxMSBGZWIgMjAxNCwgUm9nZXIgd3JvdGU6Cgo+IE9uIDAyLzEwLzIwMTQgMDc6MzAg UE0sIExlZSBKb25lcyB3cm90ZToKPiA+PkZyb206IFJvZ2VyIFRzZW5nIDxyb2dlcmFibGVAcmVh bHRlay5jb20+Cj4gPj4KPiA+PlJlYWx0ZWsgVVNCIGNhcmQgcmVhZGVyIHByb3ZpZGVzIGEgY2hh bm5lbCB0byB0cmFuc2ZlciBjb21tYW5kIG9yIGRhdGEgdG8gZmxhc2gKPiA+Pm1lbW9yeSBjYXJk cy4gVGhpcyBkcml2ZXIgZXhwb3J0cyBob3N0IGluc3RhbmNlcyBmb3IgbW1jIGFuZCBtZW1zdGlj ayBzdWJzeXN0ZW1zCj4gPj5hbmQgaGFuZGxlcyBiYXNpYyB3b3Jrcy4KPiA+Pgo+ID4+U2lnbmVk LW9mZi1ieTogUm9nZXIgVHNlbmcgPHJvZ2VyYWJsZUByZWFsdGVrLmNvbT4KPiA+Pi0tLQo+ID4+ ICBkcml2ZXJzL21mZC9LY29uZmlnICAgICAgICAgIHwgIDEwICsKPiA+PiAgZHJpdmVycy9tZmQv TWFrZWZpbGUgICAgICAgICB8ICAgMSArCj4gPj4gIGRyaXZlcnMvbWZkL3J0c3hfdXNiLmMgICAg ICAgfCA3NjAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4+ ICBpbmNsdWRlL2xpbnV4L21mZC9ydHN4X3VzYi5oIHwgNjI4ICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCj4gPj4gIDQgZmlsZXMgY2hhbmdlZCwgMTM5OSBpbnNlcnRpb25zKCsp Cj4gPj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL21mZC9ydHN4X3VzYi5jCj4gPj4gIGNy ZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL2xpbnV4L21mZC9ydHN4X3VzYi5oCj4gPgo+ID5BcHBs aWVkIHdpdGggR3JlZydzIEFjay4KPiA+Cj4gVGhhbmtzLiBCdXQgSSBoYXZlIHRvIG1vZGlmeSBz b21lIHBsYWNlcyBpbiBQQVRDSCAyLzMgYW5kIDMvMwo+IGFjY29yZGluZyB0byBVbGYncyBzdWdn ZXN0aW9uLiBJIHdpbGwgcmVzZW5kIHY0IGxhdGVyIGJ1dCBjdXJyZW50bHkKPiBJIGRvbid0IHBs YW4gdG8gY2hhbmdlIHRoZSAxLzMgcGFydChmb3IgbWZkKSBpbiBpdC4KPiAKPiBXb3VsZCB5b3Ug d2FpdCBmb3IgYW5kIHJlLWFwcGx5IHRoZSB2NCBzdWJtaXNzaW9uIG9yIGdpdmUgYW55IGFkdmlj ZT8KClllcywgbm8gcHJvYmxlbS4KCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWljcm9lbGVjdHJv bmljcyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2Fy ZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBtYWls aW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2Lmxp bnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750972AbaBKKCp (ORCPT ); Tue, 11 Feb 2014 05:02:45 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:37309 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbaBKKCk (ORCPT ); Tue, 11 Feb 2014 05:02:40 -0500 Date: Tue, 11 Feb 2014 10:02:33 +0000 From: Lee Jones To: Roger Cc: Samuel Ortiz , Chris Ball , Greg Kroah-Hartman , Maxim Levitsky , Alex Dubov , Dan Carpenter , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, driverdev-devel@linuxdriverproject.org, wei_wang@realsil.com.cn, micky_ching@realsil.com.cn, Ulf Hansson Subject: Re: [PATCH v3 1/3] mfd: Add realtek USB card reader driver Message-ID: <20140211100233.GK32042@lee--X1> References: <1391697307-23457-1-git-send-email-rogerable@realtek.com> <1391697307-23457-2-git-send-email-rogerable@realtek.com> <20140210113054.GE21522@lee--X1> <52F9F012.8030302@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <52F9F012.8030302@realtek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Feb 2014, Roger wrote: > On 02/10/2014 07:30 PM, Lee Jones wrote: > >>From: Roger Tseng > >> > >>Realtek USB card reader provides a channel to transfer command or data to flash > >>memory cards. This driver exports host instances for mmc and memstick subsystems > >>and handles basic works. > >> > >>Signed-off-by: Roger Tseng > >>--- > >> drivers/mfd/Kconfig | 10 + > >> drivers/mfd/Makefile | 1 + > >> drivers/mfd/rtsx_usb.c | 760 +++++++++++++++++++++++++++++++++++++++++++ > >> include/linux/mfd/rtsx_usb.h | 628 +++++++++++++++++++++++++++++++++++ > >> 4 files changed, 1399 insertions(+) > >> create mode 100644 drivers/mfd/rtsx_usb.c > >> create mode 100644 include/linux/mfd/rtsx_usb.h > > > >Applied with Greg's Ack. > > > Thanks. But I have to modify some places in PATCH 2/3 and 3/3 > according to Ulf's suggestion. I will resend v4 later but currently > I don't plan to change the 1/3 part(for mfd) in it. > > Would you wait for and re-apply the v4 submission or give any advice? Yes, no problem. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog