From: Dan Carpenter <dan.carpenter@oracle.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, Richard Weinberger <richard@nod.at>,
Martin Walch <walch.martin@web.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: default to "y" in Kconfig
Date: Tue, 11 Feb 2014 15:53:06 +0300 [thread overview]
Message-ID: <20140211125306.GW26722@mwanda> (raw)
In-Reply-To: <1392121892.13064.9.camel@x220>
On Tue, Feb 11, 2014 at 01:31:32PM +0100, Paul Bolle wrote:
> Two Kconfig entries for this driver default to (uppercase) "Y". But in
> Kconfig (lowercase) "y" is a magic symbol. "Y" is an ordinary symbol.
> As "Y" is never set these Kconfig symbols will also not be set by
> default.
>
> So use "default y" here, as was clearly intended.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> This patch will enable code that used to be disabled. Since this is in
> staging, that should be OK. This might also uncover warnings or errors.
> I didn't test it, anyhow.
>
> This patch also deserves a
> Reported-by: Martin Walch <walch.martin@web.de>
>
> line, but that apparently requires Martin's permission.
>
You've pretty much given Martin's secret assistance away already on a
public mailing list. Next time just add the Reported-by. :P
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-11 12:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 12:31 [PATCH] staging: r8188eu: default to "y" in Kconfig Paul Bolle
2014-02-11 12:53 ` Dan Carpenter [this message]
2014-02-11 13:01 ` Paul Bolle
2014-02-11 13:17 ` Dan Carpenter
2014-02-13 23:22 ` Paul Bolle
2014-02-14 9:30 ` [patch] Documentation/SubmittingPatches: Reported-by tags and permission Dan Carpenter
2014-02-14 23:34 ` Randy Dunlap
2014-10-28 13:04 ` Jonathan Corbet
2014-10-28 16:58 ` Jason Cooper
2014-10-28 17:41 ` Jonathan Corbet
2014-10-29 10:01 ` [patch v2] " Dan Carpenter
2014-10-29 12:57 ` Jonathan Corbet
2014-10-29 15:50 ` Rob Landley
2014-02-12 0:09 ` [PATCH] staging: r8188eu: default to "y" in Kconfig Martin Walch
2014-02-12 0:25 ` Paul Bolle
2014-02-12 0:37 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211125306.GW26722@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=richard@nod.at \
--cc=walch.martin@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.