From: Mike Snitzer <snitzer@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Junichi Nomura <j-nomura@ce.jp.nec.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Alasdair Kergon <agk@redhat.com>
Subject: Re: [PATCH 4/7] dm mpath: remove process_queued_ios()
Date: Tue, 11 Feb 2014 10:55:53 -0500 [thread overview]
Message-ID: <20140211155552.GB27812@redhat.com> (raw)
In-Reply-To: <52F9F18A.9000309@suse.de>
On Tue, Feb 11 2014 at 4:46am -0500,
Hannes Reinecke <hare@suse.de> wrote:
> On 02/10/2014 02:30 PM, Mike Snitzer wrote:
> >
> > Just to verify, this seems to be the only outstanding question for this
> > patchset?
> >
> > What value are you using for HZ? If this portion of the change does
> > turn out to be meaningul: Rather than tieing to HZ should we just use an
> > explicitly non-zero value for __pg_init_all_paths()'s @min_delay?
> >
> The actual amount here is irrelevant, as long as it's non-zero.
> It's just there to force execution of the work item off the current
> thread.
I'm aware we just need a non-zero value. My concern, as originally
raised by Junichi in an earlier reply when you had it as HZ/50, is that
the value could be 0 if HZ is really small. While unlikely I see no
point allowing the variable nature of HZ compromise passing a non-zero
value here. Best to just be explicit by passing 1 or something.
All said, the question of why this is actually needed remains. I trust
you're working on answering that via reproducer (by not forcing the use
of workqueue context)?
next prev parent reply other threads:[~2014-02-11 15:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 10:54 [PATCHv7 0/7] dm-multipath: push back requests instead of queueing Hannes Reinecke
2014-02-04 10:54 ` [PATCH 1/7] dm mpath: do not call pg_init when it is already running Hannes Reinecke
2014-02-04 10:54 ` [PATCH 2/7] dm table: add dm_table_run_md_queue_async Hannes Reinecke
2014-02-04 10:54 ` [PATCH 3/7] dm mpath: push back requests instead of queueing Hannes Reinecke
2014-02-04 10:54 ` [PATCH 4/7] dm mpath: remove process_queued_ios() Hannes Reinecke
2014-02-04 11:26 ` Junichi Nomura
2014-02-04 11:31 ` Hannes Reinecke
2014-02-10 13:30 ` Mike Snitzer
2014-02-11 9:46 ` Hannes Reinecke
2014-02-11 15:55 ` Mike Snitzer [this message]
2014-02-11 18:03 ` Hannes Reinecke
2014-02-11 16:29 ` Mike Snitzer
2014-02-12 2:37 ` Junichi Nomura
2014-02-04 10:54 ` [PATCH 5/7] dm mpath: reduce memory pressure when requeuing Hannes Reinecke
2014-02-04 10:54 ` [PATCH 6/7] dm mpath: remove map_io() Hannes Reinecke
2014-02-04 10:54 ` [PATCH 7/7] dm mpath: remove extra nesting in map function Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2014-02-03 20:28 [PATCH v6 0/7] dm-multipath: push back requests instead of queueing Mike Snitzer
2014-02-03 20:28 ` [PATCH 4/7] dm mpath: remove process_queued_ios() Mike Snitzer
2014-02-04 3:24 ` Junichi Nomura
2014-02-04 8:18 ` Hannes Reinecke
2014-02-04 8:55 ` Junichi Nomura
2014-02-04 9:08 ` Hannes Reinecke
2014-02-04 9:27 ` Junichi Nomura
2014-02-04 9:45 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211155552.GB27812@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=j-nomura@ce.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.