All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: Olaf Hering <olaf-QOLJcTWqO2uzQB+pC5nmwQ@public.gmane.org>,
	Mailing-List fedora-kernel
	<kernel-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A@public.gmane.org>,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Josh Boyer <jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	poma <pomidorabelisima-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Linux Kernel list
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Justin M. Forbes"
	<jforbes-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: WARNING: CPU: 1 PID: 0 at kernel/time/tick-broadcast.c:668 tick_broadcast_oneshot_control+0x17d/0x190()
Date: Tue, 11 Feb 2014 17:27:21 +0100	[thread overview]
Message-ID: <20140211162720.GA3729@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402111702090.21991-3cz04HxQygjZikZi3RtOZ1XZhhPuCNm+@public.gmane.org>

> > I came with a below patch, which also clear pending mask, but perhaps
> 
> Fun. I came up with the exact same solution independent of you and I
> tested it on real C1E contaminated hardware.
> 
> > oneshot_mask should not be cleared on tick_broadcast_setup_oneshot(),
> > or should be cleared only conditionally, or some other solution is
> 
> We can do it unconditionally. It creates consistent state in all
> corner cases.
> 
> There are other solutions to the problem, but that needs a major
> rework of the broadcast code. I so wish that this mess would have
> never been necessary at all ...

Thomas, please post/apply patch, which you think is the most
appropriate.

Thanks
Stanislaw
_______________________________________________
kernel mailing list
kernel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/kernel

WARNING: multiple messages have this Message-ID (diff)
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: poma <pomidorabelisima@gmail.com>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-pm@vger.kernel.org, Olaf Hering <olaf@aepfle.de>,
	Dave Jones <davej@redhat.com>,
	"Justin M. Forbes" <jforbes@redhat.com>,
	Josh Boyer <jwboyer@redhat.com>,
	Mailing-List fedora-kernel <kernel@lists.fedoraproject.org>
Subject: Re: WARNING: CPU: 1 PID: 0 at kernel/time/tick-broadcast.c:668 tick_broadcast_oneshot_control+0x17d/0x190()
Date: Tue, 11 Feb 2014 17:27:21 +0100	[thread overview]
Message-ID: <20140211162720.GA3729@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402111702090.21991@ionos.tec.linutronix.de>

> > I came with a below patch, which also clear pending mask, but perhaps
> 
> Fun. I came up with the exact same solution independent of you and I
> tested it on real C1E contaminated hardware.
> 
> > oneshot_mask should not be cleared on tick_broadcast_setup_oneshot(),
> > or should be cleared only conditionally, or some other solution is
> 
> We can do it unconditionally. It creates consistent state in all
> corner cases.
> 
> There are other solutions to the problem, but that needs a major
> rework of the broadcast code. I so wish that this mess would have
> never been necessary at all ...

Thomas, please post/apply patch, which you think is the most
appropriate.

Thanks
Stanislaw

  parent reply	other threads:[~2014-02-11 16:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10  3:42 WARNING: CPU: 1 PID: 0 at kernel/time/tick-broadcast.c:668 tick_broadcast_oneshot_control+0x17d/0x190() poma
2014-02-10 10:06 ` Thomas Gleixner
     [not found]   ` <alpine.DEB.2.02.1402101056260.21991-3cz04HxQygjZikZi3RtOZ1XZhhPuCNm+@public.gmane.org>
2014-02-10 18:59     ` poma
2014-02-10 18:59       ` poma
     [not found]       ` <52F9219B.5020003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-11  8:23         ` Stanislaw Gruszka
2014-02-11  8:23           ` Stanislaw Gruszka
2014-02-11 16:07           ` Thomas Gleixner
     [not found]             ` <alpine.DEB.2.02.1402111702090.21991-3cz04HxQygjZikZi3RtOZ1XZhhPuCNm+@public.gmane.org>
2014-02-11 16:27               ` Stanislaw Gruszka [this message]
2014-02-11 16:27                 ` Stanislaw Gruszka
2014-02-11 14:25   ` Thomas Gleixner
     [not found]     ` <alpine.DEB.2.02.1402111434180.21991-3cz04HxQygjZikZi3RtOZ1XZhhPuCNm+@public.gmane.org>
2014-02-11 20:44       ` poma
2014-02-11 20:44         ` poma
2014-02-13 20:57     ` [tip:timers/urgent] tick: Clear broadcast pending bit when switching to oneshot tip-bot for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140211162720.GA3729@redhat.com \
    --to=sgruszka-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=jforbes-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=kernel-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=olaf-QOLJcTWqO2uzQB+pC5nmwQ@public.gmane.org \
    --cc=pomidorabelisima-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.