From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislaw Gruszka Subject: Re: WARNING: CPU: 1 PID: 0 at kernel/time/tick-broadcast.c:668 tick_broadcast_oneshot_control+0x17d/0x190() Date: Tue, 11 Feb 2014 17:27:21 +0100 Message-ID: <20140211162720.GA3729@redhat.com> References: <52F84A9B.5020008@gmail.com> <52F9219B.5020003@gmail.com> <20140211082306.GA1528@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-bounces-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A@public.gmane.org Errors-To: kernel-bounces-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A@public.gmane.org To: Thomas Gleixner Cc: Olaf Hering , Mailing-List fedora-kernel , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Josh Boyer , poma , Linux Kernel list , "Justin M. Forbes" List-Id: linux-pm@vger.kernel.org PiA+IEkgY2FtZSB3aXRoIGEgYmVsb3cgcGF0Y2gsIHdoaWNoIGFsc28gY2xlYXIgcGVuZGluZyBt YXNrLCBidXQgcGVyaGFwcwo+IAo+IEZ1bi4gSSBjYW1lIHVwIHdpdGggdGhlIGV4YWN0IHNhbWUg c29sdXRpb24gaW5kZXBlbmRlbnQgb2YgeW91IGFuZCBJCj4gdGVzdGVkIGl0IG9uIHJlYWwgQzFF IGNvbnRhbWluYXRlZCBoYXJkd2FyZS4KPiAKPiA+IG9uZXNob3RfbWFzayBzaG91bGQgbm90IGJl IGNsZWFyZWQgb24gdGlja19icm9hZGNhc3Rfc2V0dXBfb25lc2hvdCgpLAo+ID4gb3Igc2hvdWxk IGJlIGNsZWFyZWQgb25seSBjb25kaXRpb25hbGx5LCBvciBzb21lIG90aGVyIHNvbHV0aW9uIGlz Cj4gCj4gV2UgY2FuIGRvIGl0IHVuY29uZGl0aW9uYWxseS4gSXQgY3JlYXRlcyBjb25zaXN0ZW50 IHN0YXRlIGluIGFsbAo+IGNvcm5lciBjYXNlcy4KPiAKPiBUaGVyZSBhcmUgb3RoZXIgc29sdXRp b25zIHRvIHRoZSBwcm9ibGVtLCBidXQgdGhhdCBuZWVkcyBhIG1ham9yCj4gcmV3b3JrIG9mIHRo ZSBicm9hZGNhc3QgY29kZS4gSSBzbyB3aXNoIHRoYXQgdGhpcyBtZXNzIHdvdWxkIGhhdmUKPiBu ZXZlciBiZWVuIG5lY2Vzc2FyeSBhdCBhbGwgLi4uCgpUaG9tYXMsIHBsZWFzZSBwb3N0L2FwcGx5 IHBhdGNoLCB3aGljaCB5b3UgdGhpbmsgaXMgdGhlIG1vc3QKYXBwcm9wcmlhdGUuCgpUaGFua3MK U3RhbmlzbGF3Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cmtlcm5lbCBtYWlsaW5nIGxpc3QKa2VybmVsQGxpc3RzLmZlZG9yYXByb2plY3Qub3JnCmh0dHBz Oi8vYWRtaW4uZmVkb3JhcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXJuZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752746AbaBKQ2Z (ORCPT ); Tue, 11 Feb 2014 11:28:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65040 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585AbaBKQ2V (ORCPT ); Tue, 11 Feb 2014 11:28:21 -0500 Date: Tue, 11 Feb 2014 17:27:21 +0100 From: Stanislaw Gruszka To: Thomas Gleixner Cc: poma , Linux Kernel list , linux-pm@vger.kernel.org, Olaf Hering , Dave Jones , "Justin M. Forbes" , Josh Boyer , Mailing-List fedora-kernel Subject: Re: WARNING: CPU: 1 PID: 0 at kernel/time/tick-broadcast.c:668 tick_broadcast_oneshot_control+0x17d/0x190() Message-ID: <20140211162720.GA3729@redhat.com> References: <52F84A9B.5020008@gmail.com> <52F9219B.5020003@gmail.com> <20140211082306.GA1528@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > I came with a below patch, which also clear pending mask, but perhaps > > Fun. I came up with the exact same solution independent of you and I > tested it on real C1E contaminated hardware. > > > oneshot_mask should not be cleared on tick_broadcast_setup_oneshot(), > > or should be cleared only conditionally, or some other solution is > > We can do it unconditionally. It creates consistent state in all > corner cases. > > There are other solutions to the problem, but that needs a major > rework of the broadcast code. I so wish that this mess would have > never been necessary at all ... Thomas, please post/apply patch, which you think is the most appropriate. Thanks Stanislaw