From: Guenter Roeck <linux@roeck-us.net>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Wim Van Sebroeck' <wim@iguana.be>,
linux-watchdog@vger.kernel.org,
'Aaro Koskinen' <aaro.koskinen@iki.fi>
Subject: Re: [PATCH 2/3] watchdog: omap_wdt: Use devm_ioremap_resource()
Date: Tue, 11 Feb 2014 12:30:42 -0800 [thread overview]
Message-ID: <20140211203042.GH11798@roeck-us.net> (raw)
In-Reply-To: <000f01cf2726$f7500210$e5f00630$%han@samsung.com>
On Tue, Feb 11, 2014 at 09:44:12PM +0900, Jingoo Han wrote:
> Use devm_ioremap_resource() in order to make the code simpler,
> and remove 'struct resource *mem' from 'struct omap_wdt_dev'
> and omap_wdt_probe(), resplectively. because the 'mem' variables
> are not used anymore. Also the redundant return value check of
> platform_get_resource() is removed, because the value is checked
> by devm_ioremap_resource().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2014-02-11 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 12:41 [PATCH 1/3] watchdog: ep93xx_wdt: Use devm_ioremap_resource() Jingoo Han
2014-02-11 12:44 ` [PATCH 2/3] watchdog: omap_wdt: " Jingoo Han
2014-02-11 20:30 ` Guenter Roeck [this message]
2014-02-11 20:58 ` Aaro Koskinen
2014-02-24 19:55 ` Wim Van Sebroeck
2014-02-11 12:45 ` [PATCH 3/3] watchdog: sp805_wdt: " Jingoo Han
2014-02-11 20:31 ` Guenter Roeck
2014-02-24 19:55 ` Wim Van Sebroeck
2014-02-11 20:29 ` [PATCH 1/3] watchdog: ep93xx_wdt: " Guenter Roeck
2014-02-24 19:55 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211203042.GH11798@roeck-us.net \
--to=linux@roeck-us.net \
--cc=aaro.koskinen@iki.fi \
--cc=jg1.han@samsung.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.