All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe MacDonald <joe@deserted.net>
To: Randy MacLeod <randy.macleod@windriver.com>
Cc: yocto@yoctoproject.org
Subject: Re: [meta-selinux][PATCH 0/4] Begin mingrating bbappends to use wildcards in place of version numbers.
Date: Tue, 11 Feb 2014 20:15:33 -0500	[thread overview]
Message-ID: <20140212011520.GA23405@deserted.net> (raw)
In-Reply-To: <52FA83EF.7000805@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 3907 bytes --]

[Re: [yocto] [meta-selinux][PATCH 0/4] Begin mingrating bbappends to use wildcards in place of version numbers.] On 14.02.11 (Tue 15:11) Randy MacLeod wrote:

> On 14-02-06 10:09 PM, Philip Tricca wrote:
> >The current trend in OE recipes seems to use a wildcard in place of version numbers for bbappends. AFAIK this is a relatively new feature but a welcome one. This is a sort of RFC in that I think it's probably best for meta-selinux to use this mechanism to keep from having to rename bbappends everytime something in oe-core changes. I guess the right way to implement this is to change the bbappends in meta-selinux when the version numbers change upstream.
> >
> 
> Hi Philip,
> 
> This might work out but I'm somewhat attached to the manual process.

It's a change I'd been advocating for quite some time now.  (Actually,
it was something I was somewhat surprised wasn't possible when I first
came to bitbake in general, so at least to me this change seems pretty
sensible.)

The risks you outline are real, but historically this hasn't shown
itself to be a significant problem so far.  The types of things this'll
hit on are characterized well in Phil's RFC set.  Stuff like sudo and
libcgroup which require bbappends but the contents haven't had any
meaningful change since the stone age.  :-)

I think this is actually a win for meta-selinux in terms of reducing the
number of commits like f0adb425.

I've already staged the proposed change in my tree and it seems happy,
so I'm inclined to merge it, FWIW.

-J.

> Manual matching shows that someone is:
>    - paying attention,
>    - fixed the bbappend version number,
>    - gotten someone else to review,
>    - hopefully built the software for at least one arch,
>    - hopefully tested run-time for at least one arch.
> 
> With a wildcard matching rule, there will be times when the
> underlying package has changed and then the recipe changes and
> perhaps code patches still apply but are to some extent broken.
> Have people accepted this as a possible outcome that they
> believe will be rare? Have you tried your approach with a few
> different oe-core baselines such as dora, random, master?
> 
> I'm not agaist this change but I'm trying to be sure that people
> agree that it's a good approach and that we've tested the idea
> with some historical changes.
> 
> Thanks,
> 
> ../Randy
> 
> 
> >Philip Tricca (4):
> >   busybox: Use wildcard for version number in busybox bbappend.
> >   libcgroup: Use wildcard for version number in libcgroup bbappend.
> >   sudo: Use wildcard for version number in sudo bbappend.
> >   libxcb: Use wildcard for version number in libxcb bbappend.
> >
> >  recipes-core/busybox/busybox_%.bbappend        |   87 ++++++++++++++++++++++++
> >  recipes-core/busybox/busybox_1.21.1.bbappend   |   87 ------------------------
> >  recipes-core/libcgroup/libcgroup_%.bbappend    |   12 ++++
> >  recipes-core/libcgroup/libcgroup_0.38.bbappend |   12 ----
> >  recipes-extended/sudo/sudo_%.bbappend          |    3 +
> >  recipes-extended/sudo/sudo_1.8.8.bbappend      |    3 -
> >  recipes-graphics/xcb/libxcb_%.bbappend         |    8 +++
> >  recipes-graphics/xcb/libxcb_1.9.3.bbappend     |    8 ---
> >  8 files changed, 110 insertions(+), 110 deletions(-)
> >  create mode 100644 recipes-core/busybox/busybox_%.bbappend
> >  delete mode 100644 recipes-core/busybox/busybox_1.21.1.bbappend
> >  create mode 100644 recipes-core/libcgroup/libcgroup_%.bbappend
> >  delete mode 100644 recipes-core/libcgroup/libcgroup_0.38.bbappend
> >  create mode 100644 recipes-extended/sudo/sudo_%.bbappend
> >  delete mode 100644 recipes-extended/sudo/sudo_1.8.8.bbappend
> >  create mode 100644 recipes-graphics/xcb/libxcb_%.bbappend
> >  delete mode 100644 recipes-graphics/xcb/libxcb_1.9.3.bbappend
> >
> 
> 
-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  reply	other threads:[~2014-02-12  1:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07  3:09 [meta-selinux][PATCH 0/4] Begin mingrating bbappends to use wildcards in place of version numbers Philip Tricca
2014-02-07  3:09 ` [meta-selinux][PATCH 1/4] busybox: Use wildcard for version number in busybox bbappend Philip Tricca
2014-02-07  3:09 ` [meta-selinux][PATCH 2/4] libcgroup: Use wildcard for version number in libcgroup bbappend Philip Tricca
2014-02-07  3:09 ` [meta-selinux][PATCH 3/4] sudo: Use wildcard for version number in sudo bbappend Philip Tricca
2014-02-07  3:09 ` [meta-selinux][PATCH 4/4] libxcb: Use wildcard for version number in libxcb bbappend Philip Tricca
2014-02-11 20:11 ` [meta-selinux][PATCH 0/4] Begin mingrating bbappends to use wildcards in place of version numbers Randy MacLeod
2014-02-12  1:15   ` Joe MacDonald [this message]
2014-02-12  2:54     ` Philip Tricca
2014-02-12 14:57       ` Randy MacLeod
2014-02-13  0:18         ` Joe MacDonald
2014-02-13  2:33           ` Pascal Ouyang
2014-02-13 15:49             ` Joe MacDonald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140212011520.GA23405@deserted.net \
    --to=joe@deserted.net \
    --cc=randy.macleod@windriver.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.