From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: mvebu: use GPIO DT defines in Armada 370/XP boards
Date: Wed, 12 Feb 2014 08:49:46 +0100 [thread overview]
Message-ID: <20140212074946.GC30814@lunn.ch> (raw)
In-Reply-To: <1392138433-12573-3-git-send-email-thomas.petazzoni@free-electrons.com>
On Tue, Feb 11, 2014 at 06:07:12PM +0100, Thomas Petazzoni wrote:
> Instead of harcoding 0 and 1 for the gpio specifications in the Armada
> 370/XP boards, use the <dt-bindings/gpio/gpio.h> header file and its
> GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW definitions.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> arch/arm/boot/dts/armada-370-mirabox.dts | 7 ++++---
> arch/arm/boot/dts/armada-370-rd.dts | 3 ++-
> arch/arm/boot/dts/armada-xp-axpwifiap.dts | 3 ++-
> arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts | 9 +++++----
> 4 files changed, 13 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-370-mirabox.dts b/arch/arm/boot/dts/armada-370-mirabox.dts
> index 944e878..2354fe0 100644
> --- a/arch/arm/boot/dts/armada-370-mirabox.dts
> +++ b/arch/arm/boot/dts/armada-370-mirabox.dts
> @@ -9,6 +9,7 @@
> */
>
> /dts-v1/;
> +#include <dt-bindings/gpio/gpio.h>
> #include "armada-370.dtsi"
Hi Thomas
What i did for kirkwood is include both gpio.h and input.h in
kirkwood.dtsi. Quite a few other systems do that, rather than each
.dts file having to include them. However i don't have a strong
opinion.
Andrew
next prev parent reply other threads:[~2014-02-12 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 17:07 [PATCH 0/3] Minor Armada 370/XP cleanups Thomas Petazzoni
2014-02-11 17:07 ` [PATCH 1/3] ARM: mvebu: remove unneeded ->map_io field for Armada 370/XP Thomas Petazzoni
2014-02-11 17:43 ` Gregory CLEMENT
2014-02-11 19:34 ` Jason Cooper
2014-02-11 17:07 ` [PATCH 2/3] ARM: mvebu: use GPIO DT defines in Armada 370/XP boards Thomas Petazzoni
2014-02-11 17:44 ` Gregory CLEMENT
2014-02-11 19:41 ` Jason Cooper
2014-02-12 7:49 ` Andrew Lunn [this message]
2014-02-12 9:24 ` Thomas Petazzoni
2014-02-12 15:52 ` Jason Cooper
2014-02-11 17:07 ` [PATCH 3/3] ARM: mvebu: use input " Thomas Petazzoni
2014-02-11 17:47 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212074946.GC30814@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.